Review main Merged

87444[BUGFIX] Ensure PDF extraction in indexed search uses first value

Benni Mack CR +2 V +2 Normal +66 −1 updated 12/11/24, 18:10

Commit message

When adding PDF metadata through Indexed search,
the FileContentParser took the last value of the
parsed list, instead of the first one, which
is typically wrong in PDF (especially embedded PDFs).

This change preserves the order properly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 12/11/24, 13:56

  2. core-ci voted on patch set 1 V +1 12/11/24, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70935

  3. Christian Kuhn commented on patch set 1 12/11/24, 14:31

    FileContentParserTest.php:58

    maybe use the LF constant here for clarity?
  4. Christian Kuhn uploaded patch set 2 V +1 12/11/24, 14:35

  5. Christian Kuhn commented on patch set 2 CR +1 V +1 12/11/24, 14:35

    FileContentParserTest.php:58 Reply

    Done
  6. core-ci voted on patch set 2 V +1 12/11/24, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70948

  7. Garvin Hicking voted on patch set 2 CR +1 V +1 12/11/24, 17:41

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 12/11/24, 18:10

  9. Christian Kuhn merged patch set 3 12/11/24, 18:10