Review main Merged Breaking

87448[!!!][TASK] Remove useless AfterMailerInitializationEvent

Christian Kuhn CR +2 V +2 Normal +54 −55 updated 12/11/24, 16:02

Commit message

Event AfterMailerInitializationEvent does not fit any
good purpose anymore: It has been introduced (as signal)
back in v7 to offer manipulation of swiftmailer configuration,
which became useless with better configuration options for
the nowadays used symfony mailer. Also, it only receives
$this (an instance of Mailer), which does not expose anything
really useful to change its state, except @internal
injectMailSettings(), which has already been called.
This event is removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 9

Review log 710

  1. Christian Kuhn uploaded patch set 1 12/11/24, 14:23

  2. core-ci voted on patch set 1 V +1 12/11/24, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70945

  3. Christian Kuhn uploaded patch set 2 V +1 12/11/24, 14:58

  4. core-ci voted on patch set 2 V -1 12/11/24, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70951

  5. Christian Kuhn uploaded patch set 3 V -1 12/11/24, 15:06

  6. core-ci voted on patch set 3 V +1 12/11/24, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70952

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 12/11/24, 15:35

  8. Oli Bartsch voted on patch set 3 CR +1 V +1 12/11/24, 16:01

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 12/11/24, 16:02

  10. Christian Kuhn merged patch set 4 12/11/24, 16:02