Review main Merged

87451[TASK] Move Mailer service config to ext:core

Christian Kuhn CR +2 V +2 Easy +9 −9 updated 12/12/24, 11:34

Commit message

The service provider configuration of ext:core low
level service `Mailer` is currently in ext:install,
but it should be in ext:core since its a core class
and services should be defined by the extension that
provides the service.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1316

  1. Christian Kuhn uploaded patch set 1 12/11/24, 16:39

  2. core-ci voted on patch set 1 V +1 12/11/24, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70958

  3. Benjamin Franzke commented on patch set 1 12/11/24, 16:51

    In general we should revise the mail-DI topic. Whenever we introduce autowired DI to mailing we can not use it in installtool login mail notification anymore. What I mean: It would be better to just disallow mailer usage without the full symfony container (can be done via a service-provider extension – I can do that) and then remove the installtool-login-mail-notification as a breaking change in v14. I'm sorry that this needs to go, but it is a source of dozen of problems and breaks whenever FluidEmail is adapted and whenever mailing tries to use DI. In general I'd like to reduce the service providers in future and use manually wired services only where really needed.
  4. Christian Kuhn commented on patch set 1 12/11/24, 16:53

    Reply

    Yes. I'm actively working on Mailer and the related classes to reduce headaches. This change is a straight pre-patch to bow to what we have at the moment.
  5. Benjamin Franzke commented on patch set 1 CR -2 12/11/24, 17:01

    Let's have a clear "future" plan before moving on with theoretical bugfixes (we need concrete bug reports with a description)
  6. Christian Kuhn abandoned the change 12/11/24, 17:03

  7. Christian Kuhn restored the change 12/12/24, 07:46

  8. Christian Kuhn uploaded patch set 2 V +1 12/12/24, 07:48

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  9. core-ci voted on patch set 2 V +1 12/12/24, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71006

  10. Christian Kuhn commented on patch set 2 12/12/24, 07:59

    Hey. I turned this into a TASK now: I'm unable to create a scenario that shows this is a true issue in v13. I just had the feeling it could trigger issues in v13, to i slated it for v13 as well and marked it a bugfix. This patch is "obviously correct" and a tiny, fully encapsulated improvement that needs no further plan as a standalone change. Would you like to remove your block or come up with a reasoning for a real issue with this change that justifies a block, please?
  11. Benjamin Franzke updated the commit message in patch set 3 V +1 12/12/24, 08:09

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  12. core-ci voted on patch set 3 V +1 12/12/24, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71007

  13. Garvin Hicking voted on patch set 3 CR +1 V +1 12/12/24, 08:50

  14. Simon Schaufelberger voted on patch set 3 CR +1 V +1 12/12/24, 09:53

  15. Christian Kuhn voted on patch set 3 CR +2 V +2 12/12/24, 11:34

  16. Christian Kuhn merged patch set 4 12/12/24, 11:34