Review main Merged

87459[TASK] Add return type to BU::getTCEFORM_TSconfig()

Christian Kuhn CR +2 V +2 Easy +1 −2 updated 12/11/24, 18:24

Commit message

It is obvious the method always returns an array.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Christian Kuhn uploaded patch set 1 12/11/24, 17:52

  2. core-ci voted on patch set 1 V +1 12/11/24, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70970

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 12/11/24, 18:06

  4. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 12/11/24, 18:07

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 12/11/24, 18:07

  6. Christian Kuhn commented on patch set 1 CR +2 V +2 12/11/24, 18:07

    merging as obvious change.
  7. Stefan Bürk voted on patch set 2 CR +1 V +1 12/11/24, 18:08

  8. Christian Kuhn commented on patch set 2 12/11/24, 18:08

    even better. thanks garvin!
  9. core-ci voted on patch set 2 V +1 12/11/24, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70971

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 12/11/24, 18:24

  11. Christian Kuhn merged patch set 3 12/11/24, 18:24