87462[BUGFIX] Avoid empty paragraphs when localizing rich text
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php3+16 −2
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+10 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/DataSet/ImportDefault.csv+9 −9
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/createPage.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/localizeContent.csv+10 −10
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/localizeContentWSynchronizationHNull.csv+7 −7
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/modifyPage.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/movePageToDifferentPageTwice.csv+1 −1
Review log 1723
-
Benni Mack uploaded patch set 1 12/11/24, 20:08
-
core-ci voted on patch set 1 V -1 12/11/24, 20:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70984
-
Benni Mack uploaded patch set 2
V -112/11/24, 22:58 -
core-ci voted on patch set 2 V -1 12/11/24, 23:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70987
-
Garvin Hicking commented on patch set 1 12/11/24, 23:10
-
Benni Mack commented on patch set 2 12/11/24, 23:11
DataMapProcessor.php:1335ReplyI'm fine with just checking for p tags. This issue is annoying and can't be solved "cleanly" in the current architecture, this I know for sure. But I still consider it "better than before" and helpful for 80% of the users out there. -
Benni Mack commented on patch set 2 CR -1 12/11/24, 23:15
OK. I do think that with our current testbase / new test options, we should finally check that bodytext with "CType=text" runs through RteHtmlparser - which our tests currently don't do. -
Benni Mack updated the commit message in patch set 3
CR -1V -112/12/24, 00:12 -
core-ci voted on patch set 3 V -1 12/12/24, 00:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70989
-
Benni Mack uploaded patch set 4
V -112/19/24, 20:42 -
Benni Mack rebased onto patch set 5 12/19/24, 20:42
-
core-ci voted on patch set 5 V +1 12/19/24, 20:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71475
-
core-ci voted on patch set 4 V -1 12/19/24, 20:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71474
-
Garvin Hicking commented on patch set 5 CR +1 V +1 12/20/24, 08:16
DataMapProcessor.php:1335ReplyAcknowledged -
Riccardo De Contardi commented on patch set 5 V +1 12/23/24, 14:34
Verified on latest master with a "Regular text element" CE, 2 languages and the sample text provided in the issue description -
Benni Mack uploaded patch set 6
CR +1V +103/08/25, 14:49 -
core-ci voted on patch set 6 V +1 03/08/25, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75352
-
Simon Schaufelberger voted on patch set 6 CR +1 V +1 03/08/25, 21:38
-
Stefan Bürk commented on patch set 6 CR -1 03/10/25, 11:20
-1 Reviewing ... -
Stefan Bürk voted on patch set 6 CR +1 V +1 03/10/25, 11:45
-
Stefan Bürk commented on patch set 6 03/10/25, 11:51
Reply
Done -
Benni Mack voted on patch set 6 CR +2 V +2 03/10/25, 12:03
-
Benni Mack merged patch set 7 03/10/25, 12:03
DataMapProcessor.php:1335