87464[BUGFIX] Use proper surrounding "html" tags for Fluid SystemEmail
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Stefan Bürk +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Stefan Bürk +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1418
-
Garvin Hicking uploaded patch set 1 12/12/24, 08:13
-
Mathias Brodala commented on patch set 2 12/12/24, 08:17
Published edit on patch set 1. -
Mathias Brodala commented on patch set 2 12/12/24, 08:18
Added linebreaks for readability, this should have been done in the first place. The removal of the data attribute would be clearer this way. On that note, please add an Important RST for this. -
core-ci voted on patch set 1 V +1 12/12/24, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71009
-
core-ci voted on patch set 2 V +1 12/12/24, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71010
-
Garvin Hicking uploaded patch set 3
V +112/12/24, 09:02 -
Garvin Hicking commented on patch set 3 12/12/24, 09:04
Reply
I already had it but forgot `git add`, doh. Thanks for the reformat, I thought about it and wasn't sure whether adding more lines to the file would be helpful. But works for me. :-) -
core-ci voted on patch set 3 V +1 12/12/24, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71017
-
Mathias Brodala voted on patch set 3 CR +1 12/12/24, 10:00
-
Georg Ringer voted on patch set 3 CR +1 V +1 12/15/24, 18:54
-
Guido Schmechel voted on patch set 3 CR +1 V +1 12/15/24, 19:52
-
Garvin Hicking uploaded patch set 4
CR +1V +112/16/24, 07:32Add tests -
core-ci voted on patch set 4 V +1 12/16/24, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71161
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 12/16/24, 09:24
-
Oli Bartsch voted on patch set 4 CR +1 V +1 12/16/24, 10:43
-
Stefan Bürk voted on patch set 4 CR +1 V +1 12/16/24, 15:11
-
Garvin Hicking commented on patch set 4 CR +2 V +2 12/16/24, 15:39
(Would like a positive vote from one of the Fluid core devs on this) -
Garvin Hicking merged patch set 5 12/16/24, 15:57