Review main Merged

87464[BUGFIX] Use proper surrounding "html" tags for Fluid SystemEmail

Garvin Hicking CR +2 V +2 Normal +89 −1 updated 12/16/24, 15:57

Commit message

Due to usage of `data-namespace-typo3-fluid="true"` in the
`<html>` declaration of the file
`EXT:core/Resources/Private/Layouts/SystemEmail.html`,
the whole `<html>..</html>` structure is removed from a sent
HTML mail.

Validation and possibly utilities like SpamAssassin may fail
or negatively score these mails due to these tags being missing.

Since the xmlns declaration of the ViewHelpers is semantically
not wrong, it can actually be included in the email by removing
the `data-namespace-typo3-fluid` attribute, instead of requiring
the alternate more intrusive Fluid ViewHelper declaration.

Custom adaptations of the SystemEmail template should be adjusted.

Note that usually mail clients or web-based mail clients usually
are fault-tolerant and replace the doctype and html tag declaration
on their own for display, so the (positive) impact of this change is
probably low.

Tests are adapted to match this expectation.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1418

  1. Garvin Hicking uploaded patch set 1 12/12/24, 08:13

  2. Mathias Brodala commented on patch set 2 12/12/24, 08:17

    Published edit on patch set 1.
  3. Mathias Brodala commented on patch set 2 12/12/24, 08:18

    Added linebreaks for readability, this should have been done in the first place. The removal of the data attribute would be clearer this way. On that note, please add an Important RST for this.
  4. core-ci voted on patch set 1 V +1 12/12/24, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71009

  5. core-ci voted on patch set 2 V +1 12/12/24, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71010

  6. Garvin Hicking uploaded patch set 3 V +1 12/12/24, 09:02

  7. Garvin Hicking commented on patch set 3 12/12/24, 09:04

    Reply

    I already had it but forgot `git add`, doh. Thanks for the reformat, I thought about it and wasn't sure whether adding more lines to the file would be helpful. But works for me. :-)
  8. core-ci voted on patch set 3 V +1 12/12/24, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71017

  9. Mathias Brodala voted on patch set 3 CR +1 12/12/24, 10:00

  10. Georg Ringer voted on patch set 3 CR +1 V +1 12/15/24, 18:54

  11. Guido Schmechel voted on patch set 3 CR +1 V +1 12/15/24, 19:52

  12. Garvin Hicking uploaded patch set 4 CR +1 V +1 12/16/24, 07:32

    Add tests
  13. core-ci voted on patch set 4 V +1 12/16/24, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71161

  14. Simon Schaufelberger voted on patch set 4 CR +1 V +1 12/16/24, 09:24

  15. Oli Bartsch voted on patch set 4 CR +1 V +1 12/16/24, 10:43

  16. Stefan Bürk voted on patch set 4 CR +1 V +1 12/16/24, 15:11

  17. Garvin Hicking commented on patch set 4 CR +2 V +2 12/16/24, 15:39

    (Would like a positive vote from one of the Fluid core devs on this)
  18. Garvin Hicking merged patch set 5 12/16/24, 15:57