Review main Merged

87470[BUGFIX] Remove not needed htmlspecialchars() usages in EXT:lowlevel

Georg Ringer CR +2 V +2 Easy +10 −10 updated 12/15/24, 17:48

Commit message

Double escaping leads to wrong labels and is not needed.
Remove the not needed usages of `htmlspecialchars()`.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jasmina Ließmann +1
    • Garvin Hicking +1
    • Eric Chavaillaz +1
    • Xavier Perseguers +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jasmina Ließmann +1
    • Garvin Hicking +1
    • Eric Chavaillaz +1
    • Xavier Perseguers +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Georg Ringer uploaded patch set 1 12/12/24, 13:34

  2. Georg Ringer commented on patch set 1 12/12/24, 13:34

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 12/12/24, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71030

  4. Xavier Perseguers voted on patch set 1 CR +1 V +1 12/12/24, 13:41

  5. Eric Chavaillaz voted on patch set 1 CR +1 V +1 12/12/24, 14:02

  6. Jasmina Ließmann voted on patch set 1 CR +1 V +1 12/12/24, 18:23

  7. Garvin Hicking commented on patch set 1 CR +1 V +1 12/13/24, 08:23

    (Replaced the labels with '<script>alert(1)</script>' and doesn't seem to trigger anything evil anywhere)
  8. Georg Ringer voted on patch set 1 CR +2 V +2 12/15/24, 17:48

  9. Georg Ringer merged patch set 2 12/15/24, 17:48