Review main Abandoned

87476[TASK] Remove internal flag from PageInformation

Georg Ringer CR 0 V 0 Easy +0 −2 updated 03/31/25, 19:02

Commit message

As the class is now activly used, e.g. in the new cObj PAGEVIEW,
the class should not be internal.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. Georg Ringer uploaded patch set 1 12/12/24, 21:13

  2. Georg Ringer commented on patch set 1 12/12/24, 21:14

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 12/12/24, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71041

  4. Benni Mack commented on patch set 1 12/12/24, 22:20

    internal means, that it's not part of TYPO3's backwards-compat promise. People often misunderstand this, and think that they cannot use this in their own code. In this case, I personally would love to have a Page object instead of the page array in there, and I hope to make this happen in v14... I assume this would be breaking then? @bo@cedev.de what do you think?
  5. Oli Bartsch commented on patch set 1 12/16/24, 14:52

    Reply

    Agree. Let's introduce a page object in v14 and afterwards remove the flag.
  6. Georg Ringer abandoned the change 03/31/25, 19:02

    this needs some more work, abandoning as cleanup