Review 12.4 Merged

87481[BUGFIX] Fix storage of empty implicitly nullable native datetime fields

Benjamin Franzke CR +2 V +2 Easy +18 −8 updated 01/08/25, 11:26

Commit message

Revert the behavioural change of #105666 to interpret native datetime
and date fields as nullable regarding persistence by default and
persist null instead of 0000-00-00, which fails with
NO_ZERO_IN_DATE enabled in MySQL.
Make sure to keep using 00:00:00 for non-nullable or nullable-undefined
time fields.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • André Buchmann +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • André Buchmann +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 811

  1. Benjamin Franzke uploaded patch set 1 12/13/24, 14:29

  2. core-ci voted on patch set 1 V -1 12/13/24, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71070

  3. Benjamin Franzke uploaded patch set 2 V -1 12/13/24, 14:37

  4. core-ci voted on patch set 2 V +1 12/13/24, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71071

  5. Benjamin Franzke updated the commit message in patch set 3 V +1 12/13/24, 14:48

  6. core-ci voted on patch set 3 V +1 12/13/24, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71072

  7. André Buchmann commented on patch set 3 CR +1 V +1 12/13/24, 17:00

    Can confirm the DH changes work in my clients TYPO3 12.4.24 instance
  8. Andreas Kienast voted on patch set 3 CR +1 01/07/25, 15:05

  9. Benni Mack voted on patch set 3 CR +1 V +1 01/08/25, 11:26

  10. Benjamin Franzke voted on patch set 3 CR +2 V +2 01/08/25, 11:26

  11. Benjamin Franzke merged patch set 4 01/08/25, 11:26