Review main Merged

87482[BUGFIX] Adjust display of form wizards button of form field 'group'

Jasmina Ließmann CR +2 V +2 Easy +6 −0 updated 12/16/24, 08:21

Commit message

The field type 'group' shows the selected elements below the field. If
an element has a longer title and the viewport was no longer sufficient
for a complete display, this resulted in the action buttons no longer
being visible and the editing area being expanded. This patch fixes
this behavior.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Jasmina Ließmann uploaded patch set 1 12/13/24, 17:27

  2. Jasmina Ließmann commented on patch set 1 V -1 12/13/24, 17:29

    This is a first approach. It needs to be checked whether this causes side effects.
  3. core-ci voted on patch set 1 V +1 12/13/24, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71076

  4. Jasmina Ließmann uploaded patch set 2 V +1 12/13/24, 17:46

  5. Jasmina Ließmann commented on patch set 2 12/13/24, 17:48

    Reply

    Since the problem does not only affect small resolutions, the adjustment has been applied to `.form-wizards-item-bottom` generally.
  6. core-ci voted on patch set 2 V +1 12/13/24, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71078

  7. Jasmina Ließmann updated the commit message in patch set 3 V +1 12/14/24, 19:08

  8. core-ci voted on patch set 3 V +1 12/14/24, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71108

  9. Georg Ringer voted on patch set 3 CR +1 V +1 12/15/24, 18:48

  10. Oli Bartsch commented on patch set 3 CR +2 V +2 12/16/24, 08:21

    Works great, thank you!
  11. Oli Bartsch merged patch set 4 12/16/24, 08:21