87484[BUGFIX] Remove redundant overrideChildTca from image fields
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 5
- Task #105823Redundant TCA overrideChildTca for image and assets field
- Bug #101277Missing alternative field in tca type file
- Task #79622Streamline CSS Styled Content and Fluid Styled Content
- Bug #56884File Upload (images) in Page Ressources, missing alt- and title tag
- Feature #33752Make use of File Abstraction Layer in Frontend
Files 8
- typo3/sysext/core/Configuration/TCA/pages.php11+4 −19
- typo3/sysext/core/Configuration/TCA/sys_file_reference.php+6 −0
- typo3/sysext/frontend/Configuration/TCA/tt_content.php9+8 −40
- typo3/sysext/seo/Configuration/TCA/Overrides/pages.php4+0 −26
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_file.php+0 −14
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_1n_inline_2_child.php4+0 −22
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_expand_inline_1_child.php4+0 −22
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_required.php+0 −7
Review log 1823
-
Nikita Hovratov uploaded patch set 1 12/14/24, 13:51
-
core-ci voted on patch set 1 V +1 12/14/24, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71101
-
Nikita Hovratov uploaded patch set 2
V +112/15/24, 16:29 -
core-ci voted on patch set 2 V +1 12/15/24, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71139
-
Oli Bartsch commented on patch set 2 CR -1 12/16/24, 11:13
pages.php:539IMO this needs to stay. Default does still define this types with the `basicoverlayPalette`.tt_content.php:327IMO this needs to stay. Default does still define this types with the `basicoverlayPalette`.tt_content.php:332IMO this needs to stay. Default does still define this types with the `basicoverlayPalette`.tt_content.php:375IMO this needs to stay. Default does still define this type with the `basicoverlayPalette`.tt_content.php:380IMO this needs to stay. Default does still define this types with the `basicoverlayPalette`.pages.php:195IMO this needs to stay. Default does still define this types with the `basicoverlayPalette`.pages.php:245IMO this needs to stay. Default does still define this types with the `basicoverlayPalette`.tx_styleguide_inline_1n_inline_2_child.php:57IMO this needs to stay. Default does still define this types with the `basicoverlayPalette`.tx_styleguide_inline_1n_inline_2_child.php:60IMO this needs to stay. Default does still define this types with the `basicoverlayPalette`.tx_styleguide_inline_expand_inline_1_child.php:57IMO this needs to stay. Default does still define this types with the `basicoverlayPalette`.tx_styleguide_inline_expand_inline_1_child.php:60IMO this needs to stay. Default does still define this types with the `basicoverlayPalette`. -
Nikita Hovratov commented on patch set 2 12/16/24, 11:45
pages.php:539ReplyAnd what does it mean if type text uses `imageOverlayPalette`?tt_content.php:332ReplyAnd what does it mean if type text uses `imageOverlayPalette`? I mean this should never be the case, as only `common-image-types` are allowed. -
Oli Bartsch commented on patch set 2 12/16/24, 14:58
pages.php:539ReplyDid not investigate. Just saw that this would be a change, which based on the commit message does not seem to be intended. -
Nikita Hovratov commented on patch set 2 12/16/24, 15:13
pages.php:539ReplyOk, I'll check if this could be in any case breaking. This looked more like a bug to me than intended behavior (And styleguide should be fine in any circumnstances). -
Nikita Hovratov uploaded patch set 3
CR -1V +112/16/24, 15:45 -
core-ci voted on patch set 3 V +1 12/16/24, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71207
-
Nikita Hovratov commented on patch set 3 12/16/24, 15:58
pages.php:539Reply@bo@cedev.de I changed this to BUGFIX now. So: `tt_content.image` -> only allows image types, so undefined and text should never occur. `tt_content.assets` -> only allows media types, so undefined and text should never occur. `pages.og_image/twitter_image` -> only image types allowed. `pages.media` -> now this could theoretically be used as text, but I've never seen this be used other than for images. But even if, the crop field is unusable. Only fields left are `alternative` and `link`. There is a very very small risk, that someone used one of these fields. But I would still go with this as a bugfix. We are still very early in v13 release cycle and if this edge case affects someone, it is very easy to fix with TCA overrides. What do you think? Alternative route: We define another palette, which has everything imageOverlayPalette has, but without `crop`. This would be 100% backwards compatible. But still, these fields only make sense with image, where they are also used by default. -
Nikita Hovratov uploaded patch set 4
V +112/16/24, 17:21 -
Nikita Hovratov updated the commit message in patch set 5 12/16/24, 17:24
-
core-ci voted on patch set 4 V +1 12/16/24, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71215
-
core-ci voted on patch set 5 V +1 12/16/24, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71216
-
Nikita Hovratov commented on patch set 5 12/16/24, 17:40
pages.php:534ReplyDonepages.php:539ReplyDonett_content.php:327ReplyDonett_content.php:332ReplyDonett_content.php:375ReplyDonett_content.php:380ReplyDonepages.php:195ReplyDonepages.php:245ReplyDonetx_styleguide_inline_1n_inline_2_child.php:57ReplyDonetx_styleguide_inline_1n_inline_2_child.php:60ReplyDonetx_styleguide_inline_expand_inline_1_child.php:57ReplyDonetx_styleguide_inline_expand_inline_1_child.php:60ReplyDone -
Oli Bartsch voted on patch set 5 CR +1 V +1 12/17/24, 10:13
-
Christian Kuhn commented on patch set 5 12/17/24, 10:53
pages.php:531hmmm. main *is* v14 (or will be). should we maybe change the main version of the patch to leave this out already, but push a v13 version that contains it? do we need additional v14 documentation? in such cases it would be fair to have distinct v13 and v14 versions from the start, since otherwise we'd have to add a follow-up patch to v14 to revome these lines again, don't we? -
Nikita Hovratov commented on patch set 5 12/17/24, 11:03
pages.php:531Reply@lolli@schwarzbu.ch I will do a follow-up patch right after this together with a breaking rst. I think it will be easier to see the difference from v13/v14 this way. -
Christian Kuhn commented on patch set 5 12/17/24, 11:40
pages.php:531ReplyAcknowledged -
Christian Kuhn voted on patch set 5 CR +1 V +1 12/17/24, 13:38
-
Oli Bartsch voted on patch set 5 CR +2 V +2 12/20/24, 08:19
-
Oli Bartsch merged patch set 6 12/20/24, 08:19
pages.php:534