Review main Merged

87485[BUGFIX] Respect aspect ratio for thumbnails in filelist and clipboard

Jasmina Ließmann CR +2 V +2 Easy +6 −7 updated 12/17/24, 08:14

Commit message

When uploading image files to the file list, the thumbnails are
initially displayed with their correct aspect ratios. If the user
reloads the file list/folder list view, the thumbnails were displayed
in a square shape, which sometimes led to a distorted display.

The patch now uses a maximum width/height instead of a fixed
width/height to display the thumbnails with their correct aspect
ratios, analogous to their initial display after uploading.

Since the clipboard display was also affected, the maximum width/height
setting was also applied to it.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1926

Show 1 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 12/14/24, 17:09

  1. core-ci voted on patch set 1 V -1 12/14/24, 17:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71102

  2. Jasmina Ließmann uploaded patch set 2 V -1 12/14/24, 17:23

  3. Jasmina Ließmann uploaded patch set 3 12/14/24, 17:25

  4. core-ci voted on patch set 2 V -1 12/14/24, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71103

  5. core-ci voted on patch set 3 V +1 12/14/24, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71104

  6. Jasmina Ließmann commented on patch set 3 12/14/24, 17:39

    Not sure if adjusting `ImagePreviewTask` is the smoother way.
  7. Jasmina Ließmann uploaded patch set 4 V +1 12/15/24, 21:40

  8. core-ci voted on patch set 4 V +1 12/15/24, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71145

  9. Garvin Hicking commented on patch set 4 CR +1 V +1 12/16/24, 07:53

    Works for me. Note that in TYPO3v12 and earlier, the CSM variants were also used directly. Adjusting the IMAGEPREVIEW processor would probably be better, but I'm not deep enough into understanding what differentiates the two processors and why they work differently from each other in terms of aspect-aware scaling. Which is why I'm voting to use the bugfix like this for now. A variant diving deeper into this will still be possible.
  10. Jasmina Ließmann updated the commit message in patch set 5 CR +1 V +1 12/16/24, 10:54

  11. core-ci voted on patch set 5 V +1 12/16/24, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71180

  12. Oli Bartsch updated the commit message in patch set 6 V +1 12/16/24, 11:02

  13. Oli Bartsch voted on patch set 6 CR +1 V +1 12/16/24, 11:02

  14. Benni Mack commented on patch set 6 CR -2 12/16/24, 11:03

    I need to check something.
  15. core-ci voted on patch set 6 V +1 12/16/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71182

  16. Jasmina Ließmann updated the commit message in patch set 7 CR +1 V +1 12/16/24, 15:00

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  17. core-ci voted on patch set 7 V +1 12/16/24, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71200

  18. Benni Mack voted on patch set 7 CR 0 12/16/24, 15:19

  19. Benni Mack commented on patch set 7 CR +1 12/16/24, 16:56

    I'm fine with this change, but bear in mind, that all (paginated) preview images in the backend will be re-created once an editor visits the file list module (just sayin). This is OK IMHO for backend since we now have a paginated view, but in general, it's good to know for everyone.
  20. Garvin Hicking commented on patch set 7 12/16/24, 17:11

    Reply

    Thanks for stating this. I wouldn't know a way around it (apart from offering an upgrade wizard that can be run on CLI that decouples this rebuild step from the backend UI). Would you say an "Important.rst" because of this would be better, to make people aware of a possible usage spike when applying the patchlevel update?
  21. Benni Mack commented on patch set 7 12/16/24, 19:50

    Reply

    nope. this is fine, but this was an issue in TYPO3 v7 back then when we accidentally changed this for all frontend images, I don't think we need an important.rst for this case.
  22. Garvin Hicking voted on patch set 7 CR +1 V +1 12/16/24, 20:30

  23. Oli Bartsch voted on patch set 7 CR +1 V +1 12/17/24, 07:07

  24. Jasmina Ließmann voted on patch set 7 CR +2 V +2 12/17/24, 08:06

  25. Jasmina Ließmann merged patch set 8 12/17/24, 08:14