87497[BUGFIX] Respect aspect ratio for thumbnails in content preview
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Garvin Hicking +1
- Andreas Kienast +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Garvin Hicking +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1217
-
Jasmina Ließmann uploaded patch set 1 12/15/24, 22:14
-
core-ci voted on patch set 1 V +1 12/15/24, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71147
-
Garvin Hicking commented on patch set 1 V +1 12/16/24, 07:51
What about `typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php` and `typo3/sysext/backend/Classes/Form/Element/FileInfoElement.php` - those also use CONTEXT_IMAGEPREVIEW? -
Jasmina Ließmann commented on patch set 1 12/16/24, 09:20
Reply
Yes, there are other occurrences of `CONTEXT_IMAGEPREVIEW`, I'm still investigating for a good solution (also for displaying thumbnails in the content preview itself). -
Jasmina Ließmann uploaded patch set 2
V +112/18/24, 19:05 -
core-ci voted on patch set 2 V +1 12/18/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71409
-
Jasmina Ließmann uploaded patch set 3
V +112/18/24, 20:37 -
core-ci voted on patch set 3 V +1 12/18/24, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71411
-
Jasmina Ließmann updated the commit message in patch set 4
V +112/18/24, 20:55 -
Jasmina Ließmann commented on patch set 4 12/18/24, 20:55
Reply
I've decided to only cover the display in the content preview in this patch, as I'm also changing the display of thumbnails in the process. -
core-ci voted on patch set 4 V +1 12/18/24, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71412
-
Jasmina Ließmann updated the commit message in patch set 5
V +112/18/24, 21:04 -
core-ci voted on patch set 5 V +1 12/18/24, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71414
-
Garvin Hicking voted on patch set 5 CR +1 V +1 12/19/24, 06:55
-
Andreas Kienast voted on patch set 5 CR +1 V +1 12/19/24, 10:12
-
Jasmina Ließmann voted on patch set 5 CR +2 V +2 12/19/24, 10:17
-
Jasmina Ließmann merged patch set 6 12/19/24, 10:27