87502[BUGFIX] flatpickr: handle proper validation of altInput
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2330
Show 35 earlier messages
-
Andreas Kienast uploaded patch set 1 12/16/24, 09:59
-
core-ci voted on patch set 1 V +1 12/16/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71175
-
Andreas Kienast rebased onto patch set 2
V +101/08/25, 11:26 -
core-ci voted on patch set 2 V +1 01/08/25, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72085
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 01/09/25, 12:36
-
Andreas Kienast commented on patch set 2 V -1 01/09/25, 15:19
This renders the field in the review module twice now... -
Simon Schaufelberger voted on patch set 2 CR 0 V 0 01/09/25, 15:59
-
Andreas Kienast uploaded patch set 3
V +101/10/25, 06:38 -
core-ci voted on patch set 3 V +1 01/10/25, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72186
-
Garvin Hicking commented on patch set 3 V -1 01/10/25, 09:36
Reply
It works for input_2 for me, but for input_3 (added yesterday, type 'datetime') this doesn't pick up?! The second field reported twice, and it doesn't go away in the review popup. It does get indicated as validated in the input field though! Screenshots: https://www.dropbox.com/s/lr1htzkudns82q2/Screenshot%202025-01-10%20at%2010.34.55.png?dl=0 https://www.dropbox.com/s/f58bo8yh2cswboi/Screenshot%202025-01-10%20at%2010.35.03.png?dl=0 (Guess it was useful to add that second field *g*) -
Simon Schaufelberger wrote 01/10/25, 10:44
Removed reviewer Simon Schaufelberger. -
Andreas Kienast uploaded patch set 4
V +101/10/25, 13:29 -
core-ci voted on patch set 4 V +1 01/10/25, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72214
-
Garvin Hicking commented on patch set 4 V +1 01/10/25, 13:47
Good news: This seems to fix and improve things! No duplication, and validation plus review module info seems to work for me (FF + Chromium on macOS) Bad news: I found two small issue that exist outside of this issue already: 1: The "X" icon of DateTime elements with this patch seems to appear and disappear after cleared. Without the patch, the "X" icon is missing all of the time, though 2: Clicking on "input_3" in the review modal does not focus the DateTime field (it does focus the tab though). Since this might be beyond scope of this patch I've created a distinct issue for it: https://forge.typo3.org/issues/105912 (The current commit message of this patch doesn't yet address the reworked functionality and needs a touchup before merge) -
Andreas Kienast updated the commit message in patch set 5
V +101/10/25, 14:50 -
Andreas Kienast commented on patch set 5 01/10/25, 14:51
Reply
Done -
Garvin Hicking voted on patch set 5 CR +1 V +1 01/10/25, 14:51
-
core-ci voted on patch set 5 V +1 01/10/25, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72216
-
Garvin Hicking wrote 01/13/25, 09:25
Topic set to FormEngine -
Andreas Kienast commented on patch set 5 01/13/25, 09:39
date-time-picker.ts:196This doesn't exist in v13, yet... -
Andreas Kienast uploaded patch set 6
CR +1V +101/13/25, 09:58 -
Andreas Kienast updated the commit message in patch set 7 01/13/25, 09:58
-
Benjamin Franzke voted on patch set 7 CR +1 V +1 01/13/25, 10:04
-
core-ci voted on patch set 6 V +1 01/13/25, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72300
-
core-ci voted on patch set 7 V +1 01/13/25, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72301
-
Garvin Hicking voted on patch set 7 CR +1 V +1 01/13/25, 10:27
-
Stefan Bürk voted on patch set 7 CR +1 V +1 01/13/25, 11:20
-
Andreas Kienast commented on patch set 7 01/13/25, 11:21
date-time-picker.ts:196ReplySolved with backporting https://review.typo3.org/c/Packages/TYPO3.CMS/+/87706 -
Andreas Kienast voted on patch set 7 CR +2 V +2 01/13/25, 11:22
-
Andreas Kienast merged patch set 8 01/13/25, 11:40