Review main Merged

87502[BUGFIX] flatpickr: handle proper validation of altInput

Andreas Kienast CR +2 V +2 Easy +11 −2 updated 01/13/25, 11:40

Commit message

flatpickr builds an alternative input field for user interaction if
enabled (which we do) to separate UI date format from system date
formats.
This adds a new layer of complexity in terms of validation: the event
`formengine.dp.change` was dispatched on the original input field, which
is the one being hidden by flatpickr, causing inproper validation of
date picker fields.

The validity state of the validated input field needs to be synchronized
with the `altInput` generated by flarpickr, therefore a custom handler
for the event `t3-formengine-postfieldvalidation` is registered.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2330

Show 35 earlier messages
  1. Andreas Kienast uploaded patch set 1 12/16/24, 09:59

  2. core-ci voted on patch set 1 V +1 12/16/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71175

  3. Andreas Kienast rebased onto patch set 2 V +1 01/08/25, 11:26

  4. core-ci voted on patch set 2 V +1 01/08/25, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72085

  5. Simon Schaufelberger voted on patch set 2 CR +1 V +1 01/09/25, 12:36

  1. Andreas Kienast commented on patch set 2 V -1 01/09/25, 15:19

    This renders the field in the review module twice now...
  2. Simon Schaufelberger voted on patch set 2 CR 0 V 0 01/09/25, 15:59

  3. Andreas Kienast uploaded patch set 3 V +1 01/10/25, 06:38

  4. core-ci voted on patch set 3 V +1 01/10/25, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72186

  5. Garvin Hicking commented on patch set 3 V -1 01/10/25, 09:36

    Reply

    It works for input_2 for me, but for input_3 (added yesterday, type 'datetime') this doesn't pick up?! The second field reported twice, and it doesn't go away in the review popup. It does get indicated as validated in the input field though! Screenshots: https://www.dropbox.com/s/lr1htzkudns82q2/Screenshot%202025-01-10%20at%2010.34.55.png?dl=0 https://www.dropbox.com/s/f58bo8yh2cswboi/Screenshot%202025-01-10%20at%2010.35.03.png?dl=0 (Guess it was useful to add that second field *g*)
  6. Simon Schaufelberger wrote 01/10/25, 10:44

    Removed reviewer Simon Schaufelberger.
  7. Andreas Kienast uploaded patch set 4 V +1 01/10/25, 13:29

  8. core-ci voted on patch set 4 V +1 01/10/25, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72214

  9. Garvin Hicking commented on patch set 4 V +1 01/10/25, 13:47

    Good news: This seems to fix and improve things! No duplication, and validation plus review module info seems to work for me (FF + Chromium on macOS) Bad news: I found two small issue that exist outside of this issue already: 1: The "X" icon of DateTime elements with this patch seems to appear and disappear after cleared. Without the patch, the "X" icon is missing all of the time, though 2: Clicking on "input_3" in the review modal does not focus the DateTime field (it does focus the tab though). Since this might be beyond scope of this patch I've created a distinct issue for it: https://forge.typo3.org/issues/105912 (The current commit message of this patch doesn't yet address the reworked functionality and needs a touchup before merge)
  10. Andreas Kienast updated the commit message in patch set 5 V +1 01/10/25, 14:50

  11. Andreas Kienast commented on patch set 5 01/10/25, 14:51

    Reply

    Done
  12. Garvin Hicking voted on patch set 5 CR +1 V +1 01/10/25, 14:51

  13. core-ci voted on patch set 5 V +1 01/10/25, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72216

  14. Garvin Hicking wrote 01/13/25, 09:25

    Topic set to FormEngine
  15. Andreas Kienast commented on patch set 5 01/13/25, 09:39

    date-time-picker.ts:196

    This doesn't exist in v13, yet...
  16. Andreas Kienast uploaded patch set 6 CR +1 V +1 01/13/25, 09:58

  17. Andreas Kienast updated the commit message in patch set 7 01/13/25, 09:58

  18. Benjamin Franzke voted on patch set 7 CR +1 V +1 01/13/25, 10:04

  19. core-ci voted on patch set 6 V +1 01/13/25, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72300

  20. core-ci voted on patch set 7 V +1 01/13/25, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72301

  21. Garvin Hicking voted on patch set 7 CR +1 V +1 01/13/25, 10:27

  22. Stefan Bürk voted on patch set 7 CR +1 V +1 01/13/25, 11:20

  23. Andreas Kienast commented on patch set 7 01/13/25, 11:21

    date-time-picker.ts:196 Reply

  24. Andreas Kienast voted on patch set 7 CR +2 V +2 01/13/25, 11:22

  25. Andreas Kienast merged patch set 8 01/13/25, 11:40