Review main Abandoned

87504[FEATURE] Add parameter to addPlugin to add FlexForms directly

Simon Schaufelberger CR 0 V 0 Normal +51 −3 updated 08/01/25, 14:32

Commit message

TODO: Write changelog file

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 4

Review log 58

  1. Simon Schaufelberger uploaded patch set 1 12/16/24, 11:53

  2. core-ci voted on patch set 1 V +1 12/16/24, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71184

  3. Stefan Bürk updated the commit message in patch set 2 V +1 12/19/24, 10:00

  4. core-ci voted on patch set 2 V +1 12/19/24, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71441

  5. Lina Wolf commented on patch set 2 02/09/25, 06:21

    How would you feel about moving your tests, which are missing in my implementation into my change https://review.typo3.org/c/Packages/TYPO3.CMS/+/88105? We could also take part of your implementation detail: Having the string non-nullable and checking for an empty string might be a better solution then my nullable parameter? On the other hand my solution already applies these changes to the core usages and contains changelog entries etc. The required TCA changes in https://review.typo3.org/c/Packages/TYPO3.CMS/+/87161 could then be based on my PR in a second step....
  6. Simon Schaufelberger uploaded patch set 3 V +1 02/19/25, 11:38

  7. core-ci voted on patch set 3 V +1 02/19/25, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74380

  8. Simon Schaufelberger abandoned the change 08/01/25, 14:32