Review main Merged

87514[BUGFIX] Allow to include YouTube live videos

Oli Bartsch CR +2 V +2 Easy +2 −1 updated 12/17/24, 09:48

Commit message

Kudos to reporter Luc Muller for the hint.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Oli Bartsch uploaded patch set 1 12/16/24, 15:39

  2. Oli Bartsch updated the commit message in patch set 2 12/16/24, 15:41

  3. core-ci voted on patch set 1 V +1 12/16/24, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71204

  4. core-ci voted on patch set 2 V +1 12/16/24, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71206

  5. Simon Schaufelberger commented on patch set 2 12/16/24, 16:02

    YouTubeHelper.php:83

    are there no tests for this?
  6. Oli Bartsch commented on patch set 2 12/17/24, 07:06

    YouTubeHelper.php:83 Reply Unresolved

    You're right, there aren't any tests for this at the moment. If you'd like to add one, that would be great – it’s always appreciated!
  7. Benni Mack voted on patch set 2 CR +1 V +1 12/17/24, 07:21

  8. Garvin Hicking voted on patch set 2 CR +1 V +1 12/17/24, 08:29

  9. Oli Bartsch voted on patch set 2 CR +2 V +2 12/17/24, 09:48

  10. Oli Bartsch merged patch set 3 12/17/24, 09:48