87516[FEATURE] Allow extending page tree filter functionality
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 5
- typo3/sysext/backend/Classes/Tree/Repository/BeforePageTreeIsFilteredEvent.phpnew+36 −0
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeFilter.phpnew+60 −0
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php4+6 −25
- typo3/sysext/backend/Tests/Functional/Tree/Repository/PageTreeRepositoryTest.php+30 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-105833-ExtendedPageTreeFilterFunctionality.rst4new+81 −0
Review log 2639
Show 714 earlier messages
-
Oli Bartsch uploaded patch set 1 12/16/24, 16:26
-
core-ci voted on patch set 1 V +1 12/16/24, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71213
-
Oli Bartsch uploaded patch set 2
V +112/17/24, 07:26 -
core-ci voted on patch set 2 V -1 12/17/24, 07:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71238
-
Oli Bartsch uploaded patch set 3
V -112/17/24, 07:49 -
Oli Bartsch uploaded patch set 4 12/17/24, 07:53
-
core-ci voted on patch set 3 V -1 12/17/24, 07:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71239
-
Oli Bartsch uploaded patch set 5 12/17/24, 07:57
-
core-ci voted on patch set 4 V +1 12/17/24, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71240
-
core-ci voted on patch set 5 V +1 12/17/24, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71241
-
Garvin Hicking updated the commit message in patch set 6
V +112/17/24, 08:15 -
core-ci voted on patch set 6 V +1 12/17/24, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71244
-
Oli Bartsch uploaded patch set 7
V +112/17/24, 08:31 -
core-ci voted on patch set 7 V +1 12/17/24, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71247
-
Oli Bartsch uploaded patch set 8
V +112/17/24, 09:20 -
core-ci voted on patch set 8 V +1 12/17/24, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71249
-
Oli Bartsch uploaded patch set 9
V +112/17/24, 09:46 -
core-ci voted on patch set 9 V +1 12/17/24, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71251
-
Oli Bartsch uploaded patch set 10
V +112/17/24, 10:04 -
core-ci voted on patch set 10 V +1 12/17/24, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71254
-
Garvin Hicking updated the commit message in patch set 11
V +112/17/24, 10:16 -
core-ci voted on patch set 11 V +1 12/17/24, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71256
-
Christian Kuhn commented on patch set 11 12/17/24, 11:50
-
Garvin Hicking commented on patch set 11 12/17/24, 12:36
Feature-105833-ExtendedPageTreeFilterFunctionality.rst:61ReplyThat's a good point. Oli's idea (and I support this) was that large instances should have the ability to remove specific "features" that the Core may introduce with patches like the frontend-URI resolving or other performance intense operations. So I do think with a note like "Handle querybuilder manipulation like a radioactive egg" this should be good. Actually, I would even be good to declare this whole PSR event internal. -
Oli Bartsch commented on patch set 11 12/17/24, 12:59
Feature-105833-ExtendedPageTreeFilterFunctionality.rst:61ReplyThe event is not intended to change queryBuilder. We pass this object just to simplify the construction of additional `$searchParts`. Therefore any change to the queryBuilder instance from TYPO3 Core is not considered API. I however agree, we should point this out in the RST and also in the event class itself. -
Oli Bartsch uploaded patch set 12
V +112/17/24, 14:14 -
Oli Bartsch commented on patch set 12 12/17/24, 14:14
Feature-105833-ExtendedPageTreeFilterFunctionality.rst:61ReplyDone -
core-ci voted on patch set 12 V +1 12/17/24, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71279
-
Benni Mack commented on patch set 12 12/17/24, 16:36
PageTreeRepository.php:561how about we move the true ID search into an Event Listener as well? -
Garvin Hicking commented on patch set 12 12/17/24, 17:29
PageTreeRepository.php:561ReplyThe problem is other event listeners also should/would operate on this UID list. That would create cross-dependencies of different event listeners. IMO this uid based search should be expansible and a common ground for event listeners to attach to, that's why I tried to talk Oli into this approach.... 😄 -
Oli Bartsch commented on patch set 12 12/17/24, 19:50
PageTreeRepository.php:561ReplyActually, this is exactly what I initially did, because this would have been the cleanest solution since all search parts are generated by listeners and no additional information needs to be passed to the event. However, as outlined by Garvin, manipulating this list might be a common use case for this event. To not require each listener to build this list from scratch, next to the problem of ordering and cross dependencies,I have removed this again in https://review.typo3.org/c/Packages/TYPO3.CMS/+/87516/8..9 and let the listener just create the initial uid list. -
Benni Mack commented on patch set 12 CR +1 V +1 12/17/24, 20:20
PageTreeRepository.php:561ReplyDone -
Garvin Hicking rebased onto patch set 13
CR +1V +112/18/24, 07:55 -
Garvin Hicking commented on patch set 13 CR +1 V +1 12/18/24, 07:59
Thanks so much for working this one out, I dig it. -
core-ci voted on patch set 13 V +1 12/18/24, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71341
-
Oli Bartsch commented on patch set 13 12/18/24, 08:10
Reply
You're welcome! It was great collaborating - glad you like it! -
Benni Mack voted on patch set 13 CR +1 V +1 12/18/24, 08:23
-
Oli Bartsch voted on patch set 13 CR +2 V +2 12/18/24, 08:24
-
Oli Bartsch merged patch set 14 12/18/24, 08:24
Feature-105833-ExtendedPageTreeFilterFunctionality.rst:61