Review main Abandoned

87517[TASK] Remove leftovers of `mod.web_layout.disableSearchBox`

Jasmina Ließmann CR 0 V 0 Easy +7 −18 updated 12/17/24, 08:48

Commit message

The TSconfig setting `mod.web_layout.disableSearchBox` has been removed
with #93077. This patch removes last remnants.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 3

Review log 78

  1. Jasmina Ließmann uploaded patch set 1 12/16/24, 19:16

  2. core-ci voted on patch set 1 V -1 12/16/24, 19:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71222

  3. Benni Mack commented on patch set 1 12/16/24, 19:51

    RecordListController.php:125

    I think this is "mod.web_list.disableSearchBox" and I think this option is still valid (unlike mod.web_layout.disableSearchBox, which was removed)
  4. Jasmina Ließmann commented on patch set 1 12/16/24, 20:44

    RecordListController.php:125 Reply

    You're right. There were indeed two settings, one for `web_layout` and one for `web_list`. The last hit I found was in the docs for 10.4. As of 11.5 "disableSearchBox" is no longer documented for `web_layout` and `web_list`.
  5. Garvin Hicking commented on patch set 1 12/16/24, 20:59

    RecordListController.php:125 Reply

    Maybe that was a docs mistake then removing the option (also confusing these two), and we need to put it back in the docs? web_list didnt seem to be intentionally removed with the linked patch?
  6. Jasmina Ließmann commented on patch set 1 V -1 12/16/24, 21:14

    -1 for now, will investigate further.

    RecordListController.php:125 Reply

    The linked patch affected `web_layout`. I hadn't noticed `web_list`, but it is indeed what is requested in `RecordListController.php`. For reference: Both settings have no effect for me. ``` mod.web_list.disableSearchBox = 1 mod.web_layout.disableSearchBox = 1 ```
  7. Jasmina Ließmann abandoned the change 12/17/24, 08:47

    Maybe it was a bit too late for me yesterday.. `mod.web_list.disableSearchBox = 1` works and ensures that the search field is hidden in the List Module (including the checkbox). I had mistakenly tested it with user TSconfig instead of page TSconfig. I therefore abandon the patch and creating a new ticket that `mod.web_list.disableSearchBox = 1` is missing in the docs.
  8. Jasmina Ließmann commented on patch set 1 12/17/24, 08:48

    RecordListController.php:125 Reply

    Maybe it was a bit too late for me yesterday.. `mod.web_list.disableSearchBox = 1` works and ensures that the search field is hidden in the List Module (including the checkbox). I had mistakenly tested it with user TSconfig instead of page TSconfig. I therefore abandon the patch and creating a new ticket that `mod.web_list.disableSearchBox = 1` is missing in the docs.