87517[TASK] Remove leftovers of `mod.web_layout.disableSearchBox`
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 3
Review log 78
-
Jasmina Ließmann uploaded patch set 1 12/16/24, 19:16
-
core-ci voted on patch set 1 V -1 12/16/24, 19:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71222
-
Benni Mack commented on patch set 1 12/16/24, 19:51
-
Jasmina Ließmann commented on patch set 1 12/16/24, 20:44
RecordListController.php:125ReplyYou're right. There were indeed two settings, one for `web_layout` and one for `web_list`. The last hit I found was in the docs for 10.4. As of 11.5 "disableSearchBox" is no longer documented for `web_layout` and `web_list`. -
Garvin Hicking commented on patch set 1 12/16/24, 20:59
RecordListController.php:125ReplyMaybe that was a docs mistake then removing the option (also confusing these two), and we need to put it back in the docs? web_list didnt seem to be intentionally removed with the linked patch? -
Jasmina Ließmann commented on patch set 1 V -1 12/16/24, 21:14
-1 for now, will investigate further.RecordListController.php:125ReplyThe linked patch affected `web_layout`. I hadn't noticed `web_list`, but it is indeed what is requested in `RecordListController.php`. For reference: Both settings have no effect for me. ``` mod.web_list.disableSearchBox = 1 mod.web_layout.disableSearchBox = 1 ``` -
Jasmina Ließmann abandoned the change 12/17/24, 08:47
Maybe it was a bit too late for me yesterday.. `mod.web_list.disableSearchBox = 1` works and ensures that the search field is hidden in the List Module (including the checkbox). I had mistakenly tested it with user TSconfig instead of page TSconfig. I therefore abandon the patch and creating a new ticket that `mod.web_list.disableSearchBox = 1` is missing in the docs. -
Jasmina Ließmann commented on patch set 1 12/17/24, 08:48
RecordListController.php:125ReplyMaybe it was a bit too late for me yesterday.. `mod.web_list.disableSearchBox = 1` works and ensures that the search field is hidden in the List Module (including the checkbox). I had mistakenly tested it with user TSconfig instead of page TSconfig. I therefore abandon the patch and creating a new ticket that `mod.web_list.disableSearchBox = 1` is missing in the docs.
RecordListController.php:125