Review main Merged

87524[TASK] Add test to ensure unused enum fields can be removed

Stefan Bürk CR +2 V +2 Easy +39 −4 updated 12/17/24, 14:27

Commit message

Reported issue #89848 with EnumType rename and drop was related
to an oversight within Doctrine DBAL handling of the rename and
creating an invalid table alteration DDL.

Doctrine/DBAL fixed that issue accidently with 3.5.0 while mark
ColumnDiff public properties internal [1].

Doctrine DBAL 3.x is included since TYPO3 v11 and even 3.5.0 is
already quite a while on board which fixes the issues for TYPO3
in the latest versions.

This change adds some tests to ensure enum type field handling
is working even that the TYPO3 EnumType has been replaced with
the Doctrine DBAL implementation meanwhile.

TYPO3 v12 backport requires SchemaMigrator test modifications
due to the test setup refactoring back in TYPO3 v12.

[1] https://github.com/doctrine/dbal/pull/5657

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Stefan Bürk uploaded patch set 1 12/17/24, 11:10

  2. core-ci voted on patch set 1 V +1 12/17/24, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71260

  3. Stefan Bürk updated the commit message in patch set 2 V +1 12/17/24, 13:50

  4. core-ci voted on patch set 2 V +1 12/17/24, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71274

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 12/17/24, 14:06

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 12/17/24, 14:17

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 12/17/24, 14:27

  8. Stefan Bürk merged patch set 3 12/17/24, 14:27