Review main Merged

87547[BUGFIX] Select form tab for acceptance tests

Anja Leichsenring CR +2 V +2 Easy +4 −1 updated 12/18/24, 09:07

Commit message

FormEngine Acceptance Tests rely on the detection of field labels
to operate successfully. When, e.g. from a previous test, the Form Tab
is not the expected one, field detection fails.

Therefor the correct tab is always selected in the setup phase.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1518

  1. Anja Leichsenring uploaded patch set 1 12/18/24, 07:09

  2. core-ci voted on patch set 1 V +1 12/18/24, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71338

  3. Garvin Hicking commented on patch set 1 12/18/24, 07:28

    Maybe streamline this more, this one also seems to miss the click('(tab-id)'): typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputRangeCest.php typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsGroupCest.php ?
  4. Anja Leichsenring commented on patch set 1 12/18/24, 07:35

    Reply

    no, that one is fine. It includes the tab into the fieldSet detection.
  5. Garvin Hicking voted on patch set 1 CR +1 V +1 12/18/24, 08:10

  6. Garvin Hicking commented on patch set 1 12/18/24, 08:11

    what about 13.4?
  7. Stefan Bürk updated the commit message in patch set 2 CR +1 V +1 12/18/24, 08:14

  8. Stefan Bürk commented on patch set 2 CR +1 V +1 12/18/24, 08:15

    Reply

    Done
  9. Garvin Hicking voted on patch set 2 CR +1 V +1 12/18/24, 08:15

  10. Anja Leichsenring commented on patch set 2 12/18/24, 08:21

    Reply

    no, 12.4 is not affected.
  11. core-ci voted on patch set 2 V +1 12/18/24, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71345

  12. Benni Mack updated the commit message in patch set 3 CR +1 V +1 12/18/24, 08:25

  13. Anja Leichsenring commented on patch set 3 12/18/24, 08:26

    Reply

    okay, leave it as is. The change does not hurt in v12.
  14. core-ci voted on patch set 3 V +1 12/18/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71349

  15. Christian Kuhn voted on patch set 3 CR +1 V +1 12/18/24, 09:03

  16. Stefan Bürk voted on patch set 3 CR +1 V +1 12/18/24, 09:07

  17. Anja Leichsenring voted on patch set 3 CR +2 V +2 12/18/24, 09:07

  18. Anja Leichsenring merged patch set 4 12/18/24, 09:07