Review main Merged

87548[TASK] Raise "phpstan/phpstan":"^2.0.4"

Anja Leichsenring CR +2 V +2 Easy +9 −9 updated 10/29/25, 06:28

Commit message

PHPStan released a new version that requires the rewording of two
baseline entries.

Used command(s):

> Build/Scripts/runTests.sh -s composer -- \
  require --dev "phpstan/phpstan":"^2.0.4"
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1012

  1. Anja Leichsenring uploaded patch set 1 12/18/24, 07:23

  2. core-ci voted on patch set 1 V +1 12/18/24, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71339

  3. Anja Leichsenring updated the commit message in patch set 2 V +1 12/18/24, 07:32

  4. core-ci voted on patch set 2 V +1 12/18/24, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71340

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 12/18/24, 07:49

  6. Georg Ringer voted on patch set 2 CR +1 V +1 12/18/24, 08:13

  7. Oli Bartsch commented on patch set 2 12/18/24, 08:14

    Do we by chance get a reference to the change which requires us to change the sorting?
  8. Stefan Bürk commented on patch set 2 12/18/24, 08:50

    Reply

    TBH - Looked through the release notes and pr's (pr changes) for now, but could not see on the first look anything which directly targets that. Maybe some coincedence for added new rule and sorting (internal) not obvious because not touched. In the end, they are the same reportings just flipt two places. I'd say spending hours of deep analyze here is kind of worthless and used in a better way. Fine for you ?
  9. Anja Leichsenring voted on patch set 2 CR +2 V +2 12/18/24, 08:50

  10. Anja Leichsenring merged patch set 3 12/18/24, 08:51

  11. Oli Bartsch commented on patch set 2 12/18/24, 08:51

    Reply

    Acknowledged
  12. Anja Leichsenring commented on patch set 3 12/18/24, 08:51

    Reply

    Done