Review main Merged

87568[BUGFIX] Set Symfony Finder "ignoreUnreadableDirs" option

Garvin Hicking CR +2 V +2 Easy +10 −8 updated 01/18/25, 09:02

Commit message

In some cases, directories without read permissions (like "lost+found")
may occur in a TYPO3 instance directory tree.

By default the Symfony Finder throws an exception and thus makes
the whole process fail, instead of skipping unreadable site config
directories for example.

With this patch, all places of the Symfony Finder usage
will utilize "ignoreUnreadableDirs()" in calls where possibly
unreadable directories should be skippable.

(Note that typo3/sysext/core/Classes/Package/PackageManager.php
utilized this option before, too.)

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 913

  1. Garvin Hicking uploaded patch set 1 12/19/24, 09:47

  2. core-ci voted on patch set 1 V +1 12/19/24, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71439

  3. core-ci commented on patch set 1 12/19/24, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71440

  4. Garvin Hicking updated the commit message in patch set 2 V +1 12/30/24, 00:05

  5. core-ci voted on patch set 2 V +1 12/30/24, 00:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71714

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 01/02/25, 13:56

  7. Garvin Hicking rebased onto patch set 3 CR +1 V +1 01/02/25, 16:41

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 01/02/25, 16:41

  9. core-ci voted on patch set 3 V +1 01/02/25, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71837

  10. Benjamin Franzke voted on patch set 3 CR +1 01/17/25, 08:28

  11. Simon Schaufelberger voted on patch set 3 CR +1 V +1 01/17/25, 15:36

  12. Garvin Hicking voted on patch set 3 CR +2 V +2 01/18/25, 09:02

  13. Garvin Hicking merged patch set 4 01/18/25, 09:02