Review main Merged

87574[BUGFIX] Do not accept fractional numbers in dimension controls

Andreas Kienast CR +2 V +2 Easy +17 −8 updated 01/06/25, 16:28

Commit message

The View module's input fields that control the size of the preview
iframe now do not accept fractional numbers anymore as those make no
sense when setting directions.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Andreas Kienast uploaded patch set 1 12/20/24, 06:54

  2. core-ci voted on patch set 1 V +1 12/20/24, 07:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71492

  3. Andreas Kienast uploaded patch set 2 V +1 12/20/24, 07:17

  4. core-ci voted on patch set 2 V +1 12/20/24, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71493

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 01/06/25, 14:03

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 01/06/25, 14:10

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 01/06/25, 16:10

  8. Christian Kuhn merged patch set 3 01/06/25, 16:28