87576[BUGFIX] Fix overflow of labels in localization mode buttons
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Marvin Buchmann +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Marvin Buchmann +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2027
Show 12 earlier messages
-
Andreas Kienast uploaded patch set 1 12/20/24, 07:34
-
core-ci voted on patch set 1 V +1 12/20/24, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71495
-
Benjamin Franzke commented on patch set 1 12/20/24, 07:55
sounds like the description of the current state, but it's the state with the patch applied (present vs imperative)of_buttons.scss:117Hm.. technically (regarding the name) this btn-class is about vertical alignment of the contents not the text content. I'd actually love to introduce a new localization-specific class here -
Andreas Kienast uploaded patch set 2 12/20/24, 09:41
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
Andreas Kienast commented on patch set 2 CR -1 12/20/24, 09:41
Remarks by @ben@bnf.dev still apply -
core-ci voted on patch set 2 V +1 12/20/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71501
-
Stefan Bürk uploaded patch set 3
CR -1V +112/23/24, 11:43 -
Stefan Bürk commented on patch set 3 12/23/24, 11:44
_buttons.scss:117ReplyNot sure about the css class nameing, but extracted it into a dedicated class and added to the localization markup. Some better suggestion to use/name it ? -
core-ci voted on patch set 3 V +1 12/23/24, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71568
-
Andreas Kienast uploaded patch set 4
V +104/01/25, 12:56 -
core-ci voted on patch set 4 V +1 04/01/25, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76785
-
Andreas Kienast updated the commit message in patch set 5
V +104/01/25, 13:42 -
Andreas Kienast commented on patch set 5 04/01/25, 13:42
Reply
DoneReply
Done_buttons.scss:117ReplyDone -
core-ci voted on patch set 5 V +1 04/01/25, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76794
-
Marvin Buchmann voted on patch set 5 CR +1 V +1 04/15/25, 14:05
-
Garvin Hicking voted on patch set 5 CR +1 V +1 04/16/25, 05:16
-
Benjamin Franzke updated the commit message in patch set 6
CR +1V +104/16/25, 06:33 -
core-ci voted on patch set 6 V +1 04/16/25, 06:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77802
-
Garvin Hicking voted on patch set 6 CR +1 V +1 04/16/25, 06:43
-
Marvin Buchmann voted on patch set 6 CR +1 V +1 04/16/25, 06:44
-
Benjamin Franzke commented on patch set 6 CR -1 04/16/25, 06:45
_wizard_localization.scss:4`flex-direction: column` and `width: 100%` are already set for `btn-block-vertical`, `white-space: normal` and `text-align: center` make sense to be applied to `.btn-block-vertical` in general (cc @benjamin.kott@outlook.com). I think we don't need a new class for that. -
Benjamin Franzke uploaded patch set 7
CR +1V +104/16/25, 06:49 -
Benjamin Franzke commented on patch set 7 04/16/25, 06:49
_wizard_localization.scss:4ReplyDone -
core-ci voted on patch set 7 V +1 04/16/25, 06:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77803
-
Marvin Buchmann voted on patch set 7 CR +1 V +1 04/16/25, 07:05
-
Andreas Kienast voted on patch set 7 CR +2 V +2 04/16/25, 07:06
-
Andreas Kienast merged patch set 8 04/16/25, 07:12