Review main Abandoned

87577[BUGFIX] Handle YAML imports in site configuration loading

Sascha Nowak CR 0 V 0 Easy +2 −2 updated 02/19/25, 21:29

Commit message

Added support for processing YAML imports
during site configuration and settings loading.
This ensures nested configurations are correctly
resolved, improving robustness and consistency.
This aligns the configuration loading with config.yaml

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 45

  1. Sascha Nowak uploaded patch set 1 12/20/24, 07:43

  2. Sascha Nowak voted on patch set 1 CR +1 V +1 12/20/24, 07:44

  3. core-ci voted on patch set 1 V +1 12/20/24, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71496

  4. Benjamin Franzke commented on patch set 1 CR -1 12/20/24, 08:03

    SiteSettingsFactory.php:87 Unresolved

    If we allow this, we'd need to implicitly mark the settings.yaml as readonly in terms of the site settings editor, as we'd break the file once updating with new values… For this reason I'm -1 this for now – sorry. Can you explain the reasons for importing in settings.yaml? Conceptionally I hoped that everything that is to be shared is put into sets and make these hard-to-maintain imports superfluous
  5. Sascha Nowak abandoned the change 02/19/25, 21:29

    Not needed anymore