87581[TASK] Add GraphicsMagick / ImageMagick f:image conversion tests
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Simon Praetorius +1
- Stefan Bürk +1
-
Verified V +2 Done
- Garvin Hicking +2
- Simon Praetorius +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 6
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/file.avifnewbinary
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/invalid-file.avinew+1 −0
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/invalid-file.exenew+1 −0
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/invalid-file.zipnew+1 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageConvertGMViewHelperTest.phpnew+544 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageConvertIMViewHelperTest.phpnew+540 −0
Review log 1217
-
Garvin Hicking uploaded patch set 1 12/21/24, 11:56
-
core-ci voted on patch set 1 V +1 12/21/24, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71524
-
Garvin Hicking rebased onto patch set 2
V +101/02/25, 16:40 -
core-ci voted on patch set 2 V -1 01/02/25, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71836
-
Garvin Hicking uploaded patch set 3
V -101/02/25, 17:32Adapt for AVIF writing in GM -
core-ci voted on patch set 3 V +1 01/02/25, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71838
-
Stefan Bürk commented on patch set 3 CR -1 01/02/25, 21:28
Going to refactor the tests tomorrow ... -
Stefan Bürk uploaded patch set 4
CR -1V +101/03/25, 12:37 -
core-ci voted on patch set 4 V +1 01/03/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71868
-
Stefan Bürk commented on patch set 4 CR +1 V +1 01/03/25, 13:15
Reply
Refactored tests to use dataprovider to ensure that each test permutation has * a clean state (db/processed files) * each test can fail on its own, and multiple test-permutation for one test does not fail on first failure completly (better overview) Granted, that is slightly slower then the manual composed multi asserting/rendering variant (patchlevel 3) but is more reliable in regards of testing strategy. -
Garvin Hicking uploaded patch set 5
CR +1V +101/03/25, 13:53Adjust commit message and inline comments -
Garvin Hicking commented on patch set 5 01/03/25, 13:58
Thanks Stefan! This works for me, and sure is nicer - thanks for talking to me about the neglectible performance impact my "from behind through the eyes" initial approach. :-) -
core-ci voted on patch set 5 V +1 01/03/25, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71870
-
Stefan Bürk voted on patch set 5 CR +1 V +1 01/03/25, 14:43
-
Simon Praetorius voted on patch set 5 CR +1 V +1 01/03/25, 17:20
-
Garvin Hicking voted on patch set 5 CR +2 V +2 01/03/25, 17:34
-
Garvin Hicking merged patch set 6 01/03/25, 17:34