Review main Merged

87581[TASK] Add GraphicsMagick / ImageMagick f:image conversion tests

Garvin Hicking CR +2 V +2 Expert +1087 −0 updated 01/03/25, 17:34

Commit message

As a pre-patch for supporting refactoring in the handling
of default conversion formats in #93981, this patch
adds new tests that cover this functionality given
a few file formats ("empty", forced: jpeg, webp, avif, tif)

Distinct test files are created for ImageMagick and
GraphicsMagick processiong.

GraphicsMagick utilizes AVIF format fallback (jpeg/png).

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Simon Praetorius +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Simon Praetorius +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1217

  1. Garvin Hicking uploaded patch set 1 12/21/24, 11:56

  2. core-ci voted on patch set 1 V +1 12/21/24, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71524

  3. Garvin Hicking rebased onto patch set 2 V +1 01/02/25, 16:40

  4. core-ci voted on patch set 2 V -1 01/02/25, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71836

  5. Garvin Hicking uploaded patch set 3 V -1 01/02/25, 17:32

    Adapt for AVIF writing in GM
  6. core-ci voted on patch set 3 V +1 01/02/25, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71838

  7. Stefan Bürk commented on patch set 3 CR -1 01/02/25, 21:28

    Going to refactor the tests tomorrow ...
  8. Stefan Bürk uploaded patch set 4 CR -1 V +1 01/03/25, 12:37

  9. core-ci voted on patch set 4 V +1 01/03/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71868

  10. Stefan Bürk commented on patch set 4 CR +1 V +1 01/03/25, 13:15

    Reply

    Refactored tests to use dataprovider to ensure that each test permutation has * a clean state (db/processed files) * each test can fail on its own, and multiple test-permutation for one test does not fail on first failure completly (better overview) Granted, that is slightly slower then the manual composed multi asserting/rendering variant (patchlevel 3) but is more reliable in regards of testing strategy.
  11. Garvin Hicking uploaded patch set 5 CR +1 V +1 01/03/25, 13:53

    Adjust commit message and inline comments
  12. Garvin Hicking commented on patch set 5 01/03/25, 13:58

    Thanks Stefan! This works for me, and sure is nicer - thanks for talking to me about the neglectible performance impact my "from behind through the eyes" initial approach. :-)
  13. core-ci voted on patch set 5 V +1 01/03/25, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71870

  14. Stefan Bürk voted on patch set 5 CR +1 V +1 01/03/25, 14:43

  15. Simon Praetorius voted on patch set 5 CR +1 V +1 01/03/25, 17:20

  16. Garvin Hicking voted on patch set 5 CR +2 V +2 01/03/25, 17:34

  17. Garvin Hicking merged patch set 6 01/03/25, 17:34