87584[BUGFIX] Create `CHAR` and `BINARY` as fixed length columns
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/BinaryDataType.php+5 −0
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/CharDataType.php+5 −0
- typo3/sysext/core/Documentation/Changelog/13.4.x/Important-105310-CreateCHARAndBINARYAsFixedLengthColumns.rstnew+353 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Important-105310-CreateCHARAndBINARYAsFixedLengthColumns.rstnew+353 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/connectionTestTable.sql+8 −1
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+28 −1
- typo3/sysext/core/Tests/Functional/Database/ConnectionTest.php+188 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/Fixtures/tablebuilder.sql+3 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/BinaryDataTypeTest.php+14 −10
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/CharDataTypeTest.php+14 −10
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php+23 −0
Review log 2641
Show 816 earlier messages
-
Stefan Bürk uploaded patch set 1 12/23/24, 16:45
-
core-ci voted on patch set 1 V -1 12/23/24, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71572
-
Stefan Bürk uploaded patch set 2
V -112/23/24, 17:30 -
core-ci voted on patch set 2 V +1 12/23/24, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71573
-
core-ci commented on patch set 2 12/23/24, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71574
-
Stefan Bürk uploaded patch set 3
V +112/28/24, 12:36 -
core-ci voted on patch set 3 V +1 12/28/24, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71673
-
Stefan Bürk rebased onto patch set 4 01/02/25, 10:33
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 4 V +1 01/02/25, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71811
-
Stefan Bürk rebased onto patch set 5
V +101/03/25, 14:16 -
core-ci voted on patch set 5 V +1 01/03/25, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71871
-
Stefan Bürk uploaded patch set 6
V +101/06/25, 13:18 -
core-ci voted on patch set 6 V +1 01/06/25, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71985
-
core-ci commented on patch set 6 01/06/25, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71987
-
Stefan Bürk uploaded patch set 7
V +101/06/25, 13:56 -
Stefan Bürk uploaded patch set 8 01/06/25, 13:58
-
core-ci voted on patch set 8 V +1 01/06/25, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71991
-
Garvin Hicking voted on patch set 8 CR +1 V +1 01/06/25, 19:23
-
Garvin Hicking commented on patch set 9
CR +1V +101/06/25, 19:23Published edit on patch set 8. -
core-ci voted on patch set 9 V -1 01/06/25, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72000
-
Garvin Hicking uploaded patch set 10
V -101/06/25, 19:40Adjust rendering of RST -
core-ci voted on patch set 10 V +1 01/06/25, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72001
-
Garvin Hicking voted on patch set 10 CR +1 V +1 01/06/25, 19:49
-
Stefan Bürk voted on patch set 10 CR -1 01/07/25, 07:59
-
Stefan Bürk uploaded patch set 11
CR +1V +101/07/25, 08:28 -
core-ci voted on patch set 11 V +1 01/07/25, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72023
-
Stefan Bürk uploaded patch set 12
V +101/07/25, 08:44 -
Garvin Hicking voted on patch set 12 CR +1 V +1 01/07/25, 08:45
-
core-ci voted on patch set 12 V +1 01/07/25, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72027
-
Stefan Bürk uploaded patch set 13
CR +1V +101/07/25, 08:55 -
core-ci voted on patch set 13 V +1 01/07/25, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72028
-
Garvin Hicking voted on patch set 13 CR +1 V +1 01/07/25, 09:56
-
Christian Kuhn commented on patch set 13 01/07/25, 10:01
currently discussing with stefan if we should target this to v12 .. -
Stefan Bürk uploaded patch set 14
CR +1V +101/07/25, 11:11 -
Stefan Bürk commented on patch set 14 01/07/25, 11:12
Reply
Removed 12.4. Maybe to "hot" for v12. If someone really needs that in a project they can backport that on their own using composer patches. -
Garvin Hicking commented on patch set 14 CR +1 V +1 01/07/25, 11:16
Good for me. Personally: If someone picked "CHAR" in their ext_tables, even if it's a "breaking change" once it gets utilized, this is what people should expect in first place and be made aware off -
core-ci voted on patch set 14 V +1 01/07/25, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72036
-
Stefan Bürk commented on patch set 14 01/07/25, 11:19
Reply
It's only breaking when database changes are applied, and only for PostgreSQL. But fine to leave that out for v12. -
Christian Kuhn voted on patch set 14 CR +1 V +1 01/07/25, 12:00
-
Stefan Bürk voted on patch set 14 CR +2 V +2 01/07/25, 12:34
-
Stefan Bürk merged patch set 15 01/07/25, 12:47