Review main Merged

87585[TASK] Throw exception for QueryBuilder UPDATE/DELETE with table joins

Stefan Bürk CR +2 V +2 Easy +47 −0 updated 01/02/25, 16:25

Commit message

Doctrine DBAL does not support table joins with `UPDATE` or `DELETE`
queries built with `QueryBuilder`. For example, using the joined table
alias within a `WHERE` condition will return a database error similar
to:

    Unknown column 'table_alias.column_name' in 'where clause'

and the underlying issue may not be obvious to the developer on first
sight.

While improving the message for developers, backporting to earlier
TYPO3 version has been intentionally left out as the change could be
breaking if invalid QueryBuilder instance preparation or reuse exists,
already mitigated for TYPO3 with #105861.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1627

Show 12 earlier messages
  1. Stefan Bürk uploaded patch set 1 12/23/24, 20:26

  2. core-ci voted on patch set 1 V -1 12/23/24, 20:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71576

  1. Stefan Bürk uploaded patch set 2 V -1 12/23/24, 20:39

  2. core-ci voted on patch set 2 V +1 12/23/24, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71577

  3. Stefan Bürk updated the commit message in patch set 3 V +1 12/23/24, 20:47

  4. Stefan Bürk updated the commit message in patch set 4 12/23/24, 20:48

  5. core-ci voted on patch set 3 V +1 12/23/24, 20:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71578

  6. core-ci voted on patch set 4 V +1 12/23/24, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71579

  7. Stefan Bürk rebased onto patch set 5 V +1 12/23/24, 21:42

  8. core-ci voted on patch set 5 V +1 12/23/24, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71581

  9. Stefan Bürk updated the commit message in patch set 6 V +1 12/23/24, 21:51

  10. core-ci voted on patch set 6 V +1 12/23/24, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71582

  11. Stefan Bürk updated the commit message in patch set 7 V +1 12/29/24, 09:18

  12. core-ci voted on patch set 7 V +1 12/29/24, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71704

  13. Stefan Bürk updated the commit message in patch set 8 V +1 12/29/24, 09:31

  14. core-ci voted on patch set 8 V +1 12/29/24, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71706

  15. Stefan Bürk updated the commit message in patch set 9 V +1 01/02/25, 14:02

  16. core-ci voted on patch set 9 V +1 01/02/25, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71828

  17. Garvin Hicking updated the commit message in patch set 10 V +1 01/02/25, 14:15

  18. Garvin Hicking voted on patch set 10 CR +1 V +1 01/02/25, 14:15

  19. Stefan Bürk uploaded patch set 11 CR +1 V +1 01/02/25, 14:21

  20. core-ci voted on patch set 10 V +1 01/02/25, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71830

  21. Garvin Hicking commented on patch set 11 CR +1 V +1 01/02/25, 14:23

    🤗
  22. Anja Leichsenring voted on patch set 11 CR +1 V +1 01/02/25, 14:24

  23. core-ci voted on patch set 11 V +1 01/02/25, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71831

  24. Stefan Bürk voted on patch set 11 CR +2 V +2 01/02/25, 16:25

  25. Stefan Bürk merged patch set 12 01/02/25, 16:25