87595[BUGFIX] Align language of inline children with their parent
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Kott +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 8
- Bug #103970Inline relations do not set the actual language
- Bug #103969Update language of inline elements is missing, leading to follow up issues
- Bug #81165Creating IRRE record within a non-default language record sets wrong sys_language_uid
- Bug #88980Translating records with FAL relation where allowLanguageSynchronization set to true
- Bug #97178Translation of a record with FAL relation not possible after language change from "-1 all" to "0 default"
- Bug #84998sys_language uid isn't updated when parent records sys_languge_uid changes
- Bug #89787Copying element with IRRE element from one language to another
- Bug #89965Copied textmedia element with sys_file_reference that has its language changed, makes the Datahandler throw up
Files 37
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+163 −0
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-103970-InlineChildrenFollowTheLanguageOfTheirParent.rstnew+121 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/Fixtures/InlineChildLanguage.csvnew+38 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/Fixtures/InlineChildLanguageChanged.csvnew+6 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/Fixtures/InlineChildLanguageChangedInWorkspace.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/Fixtures/InlineChildLanguageOfCyclicRelation.csvnew+6 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/Fixtures/InlineChildLanguageOfMmRelation.csvnew+6 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/Fixtures/InlineChildLanguageOfNewParentWithoutLanguageAccess.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/InlineChildLanguageTest.phpnew+110 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/Modify/DataSet/addFileReferenceToContentInLanguage.csvnew+13 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/Modify/DataSet/changeLanguageOfContentWFileReferenceNLocalize.csvnew+14 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/Modify/DataSet/copyLocalizedContentToDifferentPageNChangeLanguage.csvnew+16 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/Modify/DataSet/createContentWFileReferenceInAllLanguages.csvnew+12 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/Modify/DataSet/createContentWFileReferenceInLanguage.csvnew+12 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/Modify/ActionTest.php+42 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/WorkspacesModify/DataSet/createContentWFileReferenceInAllLanguages.csvnew+12 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/WorkspacesModify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/WorkspacesPublish/DataSet/createContentWFileReferenceInAllLanguages.csvnew+12 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/WorkspacesPublish/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/FAL/AbstractActionTestCase.php+94 −0
Show 17 more files
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/Modify/DataSet/changeLanguageOfParentContent.csvnew+25 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/Modify/DataSet/createParentContentInAllLanguagesNHotelNOfferChildren.csvnew+28 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/Modify/ActionTest.php+14 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesDiscard/DataSet/changeLanguageOfParentContent.csvnew+24 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesDiscard/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesModify/DataSet/changeLanguageOfParentContent.csvnew+28 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesModify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesPublish/DataSet/changeLanguageOfParentContent.csvnew+24 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesPublish/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/AbstractActionTestCase.php+21 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/changeLanguageOfParentContentNLocalizeWSynchronization.csvnew+22 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/createParentContentInAllLanguagesNChildrenSubmittedFirst.csvnew+19 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/createParentContentInAllLanguagesNHotelNOfferChildren.csvnew+19 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/ActionTest.php+21 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesPublish/DataSet/createParentContentInAllLanguagesNHotelNOfferChildren.csvnew+19 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesPublish/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/AbstractActionTestCase.php+56 −0
Review log 3855
Show 2030 earlier messages
-
Sybille Peters uploaded patch set 1 12/28/24, 09:43
-
Sybille Peters commented on patch set 1 12/28/24, 09:46
The patch still needs (functional) tests.Are we allowed to have several Resolves here? -
Sybille Peters commented on patch set 1 V -1 12/28/24, 09:47
Should manually test all referenced issues. -
Sybille Peters commented on patch set 1 12/28/24, 09:49
Should we add an Upgrade Wizard to make sure existing records are fixed? Are we allowed to backport an Upgrade Wizard to version 13.4? -
core-ci voted on patch set 1 V -1 12/28/24, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71665
-
Sybille Peters uploaded patch set 2
V -112/28/24, 10:22 -
Sybille Peters commented on patch set 1 V +1 12/28/24, 10:30
Reply
Manually tested and confirmed it resolves all issues: 81165, 88980, 103969, 103970 -
core-ci voted on patch set 2 V -1 12/28/24, 10:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71666
-
Sybille Peters uploaded patch set 3
V -112/28/24, 10:32 -
core-ci voted on patch set 3 V -1 12/28/24, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71667
-
Sybille Peters uploaded patch set 4
V -112/28/24, 11:38 -
core-ci voted on patch set 4 V -1 12/28/24, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71668
-
Sybille Peters uploaded patch set 5
V -112/28/24, 11:53 -
core-ci voted on patch set 5 V -1 12/28/24, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71669
-
Sybille Peters uploaded patch set 6
V -112/28/24, 12:10 -
core-ci voted on patch set 6 V -1 12/28/24, 12:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71671
-
Sybille Peters uploaded patch set 7
V -112/29/24, 07:20 -
core-ci voted on patch set 7 V +1 12/29/24, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71692
-
Sybille Peters uploaded patch set 8
V +112/29/24, 08:46 -
Sybille Peters commented on patch set 8 12/29/24, 08:47
Reply
Tests have been added. Still missing tests for https://forge.typo3.org/issues/88980 -
core-ci voted on patch set 8 V +1 12/29/24, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71695
-
Sybille Peters commented on patch set 8 12/29/24, 17:48
Reply
https://forge.typo3.org/issues/88980 will not occur if https://forge.typo3.org/issues/103970 is solved. Tests cover all cases. -
Garvin Hicking commented on patch set 8 12/30/24, 00:15
That would be one great multi-resolve. I hope we can adress this. Thank you!Reply
Yes, this is possible :-) -
Sybille Peters uploaded patch set 9
V +112/30/24, 09:38 -
core-ci voted on patch set 9 V +1 12/30/24, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71730
-
Sybille Peters uploaded patch set 10
V +112/30/24, 10:11 -
core-ci voted on patch set 10 V +1 12/30/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71731
-
Sybille Peters commented on patch set 10 CR -1 01/05/25, 08:34
foreign_match_fields is currently not considered, it should be considered as well, see https://docs.typo3.org/m/typo3/reference-tca/main/en-us/ColumnsConfig/Type/Inline/Index.html#confval-inline-foreign-match-fields -
Sybille Peters commented on patch set 10 01/05/25, 08:36
Currently, only parent / child relation with foreign_table / foreign_table_field / foreign_field in parent record is considered (see typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield) Relations where foreign_table_field and foreign_field are not set and the relation stored as csv in parent field are not considered, see typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_csv/ -
Sybille Peters commented on patch set 10 01/15/25, 10:28
See also already merged similar patch for copying elements: "Sync language of inline children on copy": https://review.typo3.org/c/Packages/TYPO3.CMS/+/86773
-
Benni Mack updated the commit message in patch set 11
CR -1V +104/22/26, 06:30 -
core-ci voted on patch set 11 V -1 04/22/26, 07:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100714
-
Benni Mack marked it work in progress 10/07/26, 09:12
-
Benni Mack commented on patch set 11 10/07/26, 09:12
marking this as WIP, I think we need to look at each issue individually. -
Benni Mack uploaded patch set 12
V -110/13/26, 16:17 -
core-ci voted on patch set 12 V +1 10/13/26, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111014
-
Benni Mack uploaded patch set 13
V +110/13/26, 20:00 -
core-ci voted on patch set 13 V +1 10/13/26, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111023
-
Benni Mack marked it ready for review 10/13/26, 21:13
-
Benni Mack commented on patch set 13 10/14/26, 06:29
Reply
lets handle this separately, as I've done with recent changes in DataHandler. Or we build it into e.g. dbdoctor?Reply
this is now coveredReply
this is now covered (CSV + foreign_field) except MM, which we should probably handle separately.Reply
Done -
Benni Mack uploaded patch set 14
V +110/14/26, 08:21 -
core-ci voted on patch set 14 V +1 10/14/26, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111055
-
Benni Mack uploaded patch set 15
V +110/15/26, 22:25 -
Benni Mack uploaded patch set 16 10/15/26, 22:28
-
Benni Mack wrote 10/15/26, 22:32
Topic set to DataHandler -
core-ci voted on patch set 15 V +1 10/15/26, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111290
-
core-ci voted on patch set 16 V +1 10/15/26, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111292
-
Benni Mack uploaded patch set 17
V +110/16/26, 17:08 -
Benni Mack marked it ready for review 10/16/26, 17:11
-
Benni Mack voted on patch set 17 CR +1 V +1 10/16/26, 17:11
-
Benni Mack commented on patch set 17 10/16/26, 17:12
That was a lot of work - it was really worth it. Thank you, Sybille, for kickstarting this! -
core-ci voted on patch set 17 V +1 10/16/26, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111385
-
Benjamin Kott voted on patch set 17 CR +1 V +1 10/17/26, 12:23
-
Benni Mack voted on patch set 17 CR +2 V +2 10/17/26, 12:29
-
Benni Mack merged patch set 18 10/17/26, 12:29