Review main Merged

87596[TASK] Use `VARCHAR` instead of `CHAR` in core `ext_tables.sql` files

Stefan Bürk CR +2 V +2 Easy +7 −7 updated 01/02/25, 11:00

Commit message

The TYPO3 parser and Tablebuilder recognizes `CHAR`
in `ext_tables.sql` files but does not transform it
as a fixed Doctrine DBAL Schema representation, thus
creating `VARCHAR` fields anyway.

CHAR database fields require careful creation of
corresponding database queries due to different
database vendor behaviour, for example PostgreSQL.

`ext_tables.sql` files of system extensions should use
the definition which is created by the database
analyzer.

This change also acts as preparation to set parsed
`CHAR` fields as fixed to enable use of these fields
for third party extension authors.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Stefan Bürk uploaded patch set 1 12/28/24, 12:22

  2. core-ci voted on patch set 1 V +1 12/28/24, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71672

  3. Garvin Hicking updated the commit message in patch set 2 V +1 12/28/24, 16:26

  4. Garvin Hicking voted on patch set 2 CR +1 V +1 12/28/24, 16:29

  5. core-ci voted on patch set 2 V +1 12/28/24, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71677

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 01/02/25, 10:35

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 01/02/25, 10:40

  8. Stefan Bürk merged patch set 3 01/02/25, 11:00