Review 13.4 Merged

87597[BUGFIX] Fix missing CType evaluation for UriBuilder

Garvin Hicking CR +2 V +2 Easy +20 −8 updated 01/02/25, 10:56

Commit message

The method "ExtensionService->getTargetPidByPlugin()" only
evaluated the combination of tt_content.CType = 'list' and
tt_content.list_type = 'pluginSignature' when preparing
the retrieval of plugin.tx_myext.view.defaultPid.

With #105538 this was fixed for TYPO3 v14 already,
and allows to properly evaluate CType scenarios.

However, for TYPO3 v13 (where "list_type" is still
allowed and only deprecated) this CType scenario was
not evaluated.

Tests are added for this behavior, and a fix is
performed to allow retrieving both ways
in the QueryBuilder based logic.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Sebastian Iffland +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 912

  1. Garvin Hicking uploaded patch set 1 12/28/24, 14:30

    init
  2. core-ci voted on patch set 1 V -1 12/28/24, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71674

  3. Garvin Hicking uploaded patch set 2 V -1 12/28/24, 15:13

  4. Garvin Hicking commented on patch set 2 12/28/24, 15:19

    Pinging @bo@cedev.de
  5. core-ci voted on patch set 2 V -1 12/28/24, 15:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71675

  6. Garvin Hicking uploaded patch set 3 V -1 12/28/24, 15:21

    Fix indentation
  7. core-ci voted on patch set 3 V +1 12/28/24, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71676

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 12/29/24, 10:10

  9. Sebastian Iffland voted on patch set 3 CR +1 01/02/25, 09:08

  10. Anja Leichsenring voted on patch set 3 CR +1 V +1 01/02/25, 10:56

  11. Stefan Bürk voted on patch set 3 CR +2 V +2 01/02/25, 10:56

  12. Stefan Bürk merged patch set 4 01/02/25, 10:56