87606[BUGFIX] Ensure folder for ENABLE_INSTALL_TOOL file exists
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 67
-
Markus Klein uploaded patch set 1 12/30/24, 19:37
-
core-ci voted on patch set 1 V +1 12/30/24, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71734
-
Garvin Hicking commented on patch set 1 V +1 12/30/24, 21:28
Seems to do the trick, but tbh I'm a bit afraid if this could have any side effects on deployment scripts...? -
Markus Klein commented on patch set 1 12/31/24, 00:22
Reply
I think no side effect, since this method is only used inside core within \TYPO3\CMS\Install\Service\EnableFileService::extendInstallToolEnableFileLifetime It will never call createInstallToolEnableFile unless the `is_file` check was true before. => directory exists. This is only directly called from TYPO3 console https://github.com/TYPO3-Console/TYPO3-Console/blob/main/Classes/Console/Command/InstallTool/UnlockInstallToolCommand.php#L47 -
Garvin Hicking voted on patch set 1 CR +1 01/02/25, 10:28
-
Stefan Bürk commented on patch set 1 CR +2 V +2 01/02/25, 11:08
Reply
Depyloment scripts creating that folder and failing needs to be adopted or have proper check anyway. And as Markus said, should not conflict anyway. -
Stefan Bürk merged patch set 2 01/02/25, 11:17