Review main Merged

87608[BUGFIX] Make install command accept create-site 'no'

Lina Wolf CR +2 V +2 Easy +5 −11 updated 01/02/25, 12:23

Commit message

When you run the setup command without parameter you are informed
that the default for "create a basic site" is "no." However using
"no" as value for either the argument `--create-site` or the
enviroment variable `TYPO3_SETUP_CREATE_SITE=no` currently causes
errors:

In SetupCommand.php line 626:

The given url for the site name is not valid! Please try again.

Instead of "normalizing" just the user input of the command prompt,
all possible input ways (prompt, argument, variable) the same way by
leaving the interpretation of the input to the validator.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Lina Wolf uploaded patch set 1 12/31/24, 07:25

  2. Lina Wolf uploaded patch set 2 12/31/24, 07:27

  3. core-ci voted on patch set 1 V +1 12/31/24, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71751

  4. core-ci voted on patch set 2 V +1 12/31/24, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71752

  5. Garvin Hicking voted on patch set 2 CR +1 12/31/24, 07:41

  6. Chris Müller updated the commit message in patch set 3 CR +1 V +1 12/31/24, 10:08

  7. core-ci voted on patch set 3 V +1 12/31/24, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71754

  8. Garvin Hicking voted on patch set 3 CR +1 12/31/24, 14:16

  9. Stefan Bürk commented on patch set 3 CR -1 01/02/25, 11:22

    Reviewing ...
  10. Stefan Bürk voted on patch set 3 CR +2 V +2 01/02/25, 11:47

  11. Stefan Bürk commented on patch set 3 01/02/25, 11:48

    Reply

    Done
  12. Stefan Bürk voted on patch set 3 CR +1 V +1 01/02/25, 11:57

  13. Garvin Hicking voted on patch set 3 V +1 01/02/25, 12:21

  14. Stefan Bürk voted on patch set 3 CR +2 V +2 01/02/25, 12:22

  15. Stefan Bürk merged patch set 4 01/02/25, 12:23