Review main Merged

87609[BUGFIX] Parse URLs with non-ASCII characters

Sybille Peters CR +2 V +2 Easy +47 −1 updated 01/02/25, 10:39

Commit message

The UrlSoftReferenceParser did not handle URLs with non-ASCII
characters in the domain, because it used a regex using a-z
to match for letters. This will not work for unicode characters
outside of the ASCII range (such as umlauts like ö).

This change replaces the ASCII letter with the unicode language
meta container `\p{L}` to extract unicode domains also from the
provided content.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Sybille Peters uploaded patch set 1 01/01/25, 09:57

  2. Sybille Peters voted on patch set 1 V +1 01/01/25, 10:00

  3. core-ci voted on patch set 1 V +1 01/01/25, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71770

  4. Stefan Bürk updated the commit message in patch set 2 V +1 01/02/25, 09:48

  5. Stefan Bürk updated the commit message in patch set 3 01/02/25, 09:49

  6. core-ci voted on patch set 2 V +1 01/02/25, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71798

  7. core-ci voted on patch set 3 V +1 01/02/25, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71799

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 01/02/25, 10:07

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 01/02/25, 10:28

  10. Stefan Bürk voted on patch set 3 CR +2 V +2 01/02/25, 10:30

  11. Stefan Bürk merged patch set 4 01/02/25, 10:39