Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
87610[BUGFIX] Fix permission problem in linkvalidator list
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 7
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/10/87610/7 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/10/87610/7 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -1 Needs a vote
- Georg Ringer +1
- Benni Mack -1
-
Verified V +1 Needs a vote
- Georg Ringer +1
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/linkvalidator/Classes/Repository/BrokenLinkRepository.php+19 −4
- typo3/sysext/linkvalidator/Classes/Repository/PagesRepository.php1+11 −5
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/BrokenLinkRepositoryTest/input.csv+3 −2
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/PagesRepositoryTest/be_groups.csvnew+6 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/PagesRepositoryTest/be_users.csvnew+8 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/Fixtures/PagesRepositoryTest/pageListContainsSubpageOfPageWithoutPermissions.csvnew+5 −0
- typo3/sysext/linkvalidator/Tests/Functional/Repository/BrokenLinkRepositoryTest.php+22 −3
- typo3/sysext/linkvalidator/Tests/Functional/Repository/PagesRepositoryTest.php+39 −0
Review log 1118
-
Sybille Peters uploaded patch set 1 01/01/25, 11:40
-
Sybille Peters wrote 01/01/25, 11:41
Topic set to Linkvalidator -
core-ci voted on patch set 1 V -1 01/01/25, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71773
-
Sybille Peters uploaded patch set 2
V -101/01/25, 12:43 -
core-ci voted on patch set 2 V +1 01/01/25, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71774
-
Sybille Peters uploaded patch set 3
V +101/03/25, 12:20 -
core-ci voted on patch set 3 V +1 01/03/25, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71867
-
Sybille Peters updated the commit message in patch set 4
V +101/03/25, 15:56 -
core-ci voted on patch set 4 V +1 01/03/25, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71872
-
Benni Mack updated the commit message in patch set 5
V +104/22/26, 06:25 -
core-ci voted on patch set 5 V -1 04/22/26, 06:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100690
-
Benni Mack uploaded patch set 6
V -109/25/26, 18:00 -
Benni Mack updated the commit message in patch set 7 09/25/26, 18:00
-
core-ci voted on patch set 6 V +1 09/25/26, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109287
-
core-ci voted on patch set 7 V +1 09/25/26, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109288
-
Oliver Klee voted on patch set 7 V +1 09/27/26, 07:30
-
Georg Ringer voted on patch set 7 CR +1 V +1 09/29/26, 13:26
-
Benni Mack commented on patch set 7 CR -1 09/30/26, 08:28
PagesRepository.php:115UnresolvedI think this might become a security isssue, so we should actually check this in PHP for the time being.