Review 12.4 Merged

87619[BUGFIX] Parse URLs with non-ASCII characters

Stefan Bürk CR +2 V +2 Easy +47 −1 updated 01/02/25, 10:40

Commit message

The UrlSoftReferenceParser did not handle URLs with non-ASCII
characters in the domain, because it used a regex using a-z
to match for letters. This will not work for unicode characters
outside of the ASCII range (such as umlauts like ö).

This change replaces the ASCII letter with the unicode language
meta container `\p{L}` to extract unicode domains also from the
provided content.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Stefan Bürk commented on patch set 1 01/02/25, 10:30

    Cherry Picked from branch 13.4.
  2. core-ci voted on patch set 1 V +1 01/02/25, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71810

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 01/02/25, 10:40

  4. Stefan Bürk merged patch set 2 01/02/25, 10:40