Review 12.4 Merged

87621[TASK] Use `VARCHAR` instead of `CHAR` in core `ext_tables.sql` files

Stefan Bürk CR +2 V +2 Easy +15 −10 updated 01/02/25, 11:00

Commit message

The TYPO3 parser and Tablebuilder recognizes `CHAR`
in `ext_tables.sql` files but does not transform it
as a fixed Doctrine DBAL Schema representation, thus
creating `VARCHAR` fields anyway.

CHAR database fields require careful creation of
corresponding database queries due to different
database vendor behaviour, for example PostgreSQL.

`ext_tables.sql` files of system extensions should use
the definition which is created by the database
analyzer.

This change also acts as preparation to set parsed
`CHAR` fields as fixed to enable use of these fields
for third party extension authors.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 34

  1. Stefan Bürk uploaded patch set 1 01/02/25, 10:51

  2. core-ci voted on patch set 1 V +1 01/02/25, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71815

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 01/02/25, 11:00

  4. Stefan Bürk merged patch set 2 01/02/25, 11:00