Review 13.4 Merged

87627[BUGFIX] Fix performance issue when resolving Extbase relations in workspaces

Benni Mack CR +2 V +2 Easy +28 −10 updated 01/02/25, 20:43

Commit message

In the workspace preview, when Extbase resolves a MM relation
(e.g. categories from a news record), the database query introduced by
commit a1f22a427f3bc49ab3fc3424859a7e2d7beaa1c9 forgets to constrain the
MM on the foreign side of the relation.

This can result in a lot of rows being fetched from the database, which
can be a huge performance issue depending on the number of relations in
the MM table.

This change enforces the foreign clause on the foreign side of the
relation.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 6

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 01/02/25, 20:34

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/02/25, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71840

  3. Benni Mack voted on patch set 1 CR +2 V +2 01/02/25, 20:43

  4. Benni Mack merged patch set 2 01/02/25, 20:43