87628[DOCS] Use ServerRequestInterface $request parameter in AbstractPlugin
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1219
-
TYPO3com uploaded patch set 1 01/03/25, 17:02
-
core-ci voted on patch set 1 V +1 01/03/25, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71873
-
Sybille Peters commented on patch set 1 01/03/25, 18:57
AbstractPlugin does not exist anymore since v13. Perhaps a note about that should be added as well -
Sybille Peters updated the commit message in patch set 2
V +101/03/25, 18:57 -
Sybille Peters updated the commit message in patch set 3 01/03/25, 18:59
-
core-ci voted on patch set 2 V +1 01/03/25, 19:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71877
-
core-ci voted on patch set 3 V +1 01/03/25, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71878
-
Garvin Hicking commented on patch set 3 CR -1 01/03/25, 19:53
Reply
IMO we do not (and IMO should not) link from changelogs to newer versions of changelogs in such cases. Hinting at the absence of AbstractPlugin is the task of the Documentation - this is already done in https://docs.typo3.org/m/typo3/reference-coreapi/12.4/en-us/ExtensionArchitecture/HowTo/FrontendPlugin/AbstractPlugin.htmlWhat I do not understand is the reference to "main" here. That seems to be a custom implementation, and probably called via TypoScript? Thus we cannot generally adapt this example? Please explain where in the TYPO3 core such a call to an AbstractPlugin's main() method is performed. -
Garvin Hicking updated the commit message in patch set 4
CR -1V +101/03/25, 20:51 -
core-ci voted on patch set 4 V +1 01/03/25, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71880
-
Garvin Hicking commented on patch set 5
V +101/03/25, 20:58Published edit on patch set 4. -
Garvin Hicking commented on patch set 5 01/03/25, 20:59
Reply
Thinking about it some more, I do think there's some sense in adding a cross reference, please see the change I pushed.Reply
Stefan talked me through it. I've adapted the changelog a bit, and the commit message, giving some background information. -
Garvin Hicking updated the commit message in patch set 6 01/03/25, 21:01
-
Garvin Hicking voted on patch set 6 CR +1 V +1 01/03/25, 21:02
-
core-ci voted on patch set 5 V +1 01/03/25, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71881
-
core-ci voted on patch set 6 V +1 01/03/25, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71882
-
Franz Holzinger commented on patch set 6 01/04/25, 13:33
Reply
The function main is used for historical reasons. The former pi_base class has the main function as the only possibility from where to start a TYPO3 extension plugin.I added a comment that the main function is there for historical reasons coming from the pi_base class. -
Stefan Bürk voted on patch set 6 CR +2 V +2 01/04/25, 15:51
-
Stefan Bürk merged patch set 7 01/04/25, 16:01