Review main Merged

87635[TASK] Update phpstan

Anja Leichsenring CR +2 V +2 Easy +8 −8 updated 01/06/25, 08:19

Commit message

Used commands:

^ Build/Scripts/runTests.sh -s composer require --dev \
	phpstan/phpstan:^2.1.1
^ Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Anja Leichsenring uploaded patch set 1 01/06/25, 06:11

  2. Anja Leichsenring updated the commit message in patch set 2 01/06/25, 06:12

  3. core-ci voted on patch set 1 V +1 01/06/25, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71958

  4. core-ci voted on patch set 2 V +1 01/06/25, 06:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71959

  5. Benjamin Franzke voted on patch set 2 CR +1 V +1 01/06/25, 06:47

  6. Lina Wolf commented on patch set 2 CR +1 01/06/25, 07:00

    Looks good to me
  7. Stefan Bürk voted on patch set 2 CR +2 V +2 01/06/25, 08:19

  8. Stefan Bürk merged patch set 3 01/06/25, 08:19