Review main Merged

87641[TASK] Adjust variable check and remove warning from PHPStan baseline

Garvin Hicking CR +2 V +2 Easy +1 −7 updated 01/06/25, 11:07

Commit message

The variable check on `$selectableItemGroups[<int>]['items']` can
be simplified. Only the method itselfs sets that self-created
temporary array structure, there is no outside manipulation of it.

Thus, if the array key 'items' is present, it will always be filled.

Executed command:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 811

  1. Garvin Hicking uploaded patch set 1 01/06/25, 08:50

  2. core-ci voted on patch set 1 V +1 01/06/25, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71969

  3. Stefan Bürk updated the commit message in patch set 2 V +1 01/06/25, 09:08

  4. Stefan Bürk updated the commit message in patch set 3 01/06/25, 09:08

  5. Stefan Bürk voted on patch set 3 CR +1 V +1 01/06/25, 09:08

  6. core-ci voted on patch set 2 V +1 01/06/25, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71970

  7. core-ci voted on patch set 3 V +1 01/06/25, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71971

  8. Anja Leichsenring voted on patch set 3 CR +1 V +1 01/06/25, 09:16

  9. Oli Bartsch voted on patch set 3 CR +1 V +1 01/06/25, 10:13

  10. Garvin Hicking voted on patch set 3 CR +2 V +2 01/06/25, 10:23

  11. Garvin Hicking merged patch set 4 01/06/25, 11:07