Review 13.4 Merged

87650[BUGFIX] Preserve correct line breaks in `<textarea>`

Benjamin Franzke CR +2 V +2 Normal +43 −19 updated 01/07/25, 08:32

Commit message

The HTML `<textarea>` element has very specific rules for leading
linefeed (0x0a) characters: if the first char of the content is a
linefeed, it is to be ignored by parsers. [1]

To represent the exact number of leading line breaks, a supplementary
linefeed character needs to be prepended to the textarea value, which
will always be ignored, but ensures that subsequent linefeeds are
respected.

[1] https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-inbody:~:text=A%20start%20tag%20whose%20tag%20name%20is%20%22textarea%22

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Benjamin Franzke commented on patch set 1 01/07/25, 08:13

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 01/07/25, 08:16

  3. core-ci voted on patch set 1 V +1 01/07/25, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72020

  4. Benjamin Franzke merged patch set 2 01/07/25, 08:32