Review 13.4 Abandoned

87651[BUGFIX] Fix several flaws in form-engine-review

Andreas Kienast CR 0 V 0 Easy +21 −10 updated 01/13/25, 10:39

Commit message

The `form-engine-review` module suffers from a few regressions in
recent changes. The change #105596 added `.has-error` to the field
labels as well, causing duplication of all entries.

This issue has been solved by storing the "related input field" in a
`Set`, which ensures unique entries by itself. Also, the label is now
fetched from the correct parent element.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 2

Review log 711

  1. Andreas Kienast uploaded patch set 1 01/07/25, 08:32

  2. core-ci voted on patch set 1 V +1 01/07/25, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72024

  3. Garvin Hicking commented on patch set 1 V -1 01/07/25, 10:59

    Currently still has issues for me in v13. EXT:styleguide doesn't validate at least RTE and SELECT fields, they do not appear in the review popup (normal inputs do now)
  4. Andreas Kienast uploaded patch set 2 V +1 01/08/25, 09:49

  5. core-ci voted on patch set 2 V +1 01/08/25, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72082

  6. Christian Kuhn updated the commit message in patch set 3 V +1 01/08/25, 11:39

  7. Christian Kuhn updated the commit message in patch set 4 01/08/25, 11:39

  8. core-ci voted on patch set 3 V +1 01/08/25, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72088

  9. core-ci voted on patch set 4 V +1 01/08/25, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72089

  10. Garvin Hicking wrote 01/13/25, 09:24

    Topic set to FormEngine
  11. Andreas Kienast abandoned the change 01/13/25, 10:39