Review main Merged

87657[TASK] Update ckeditor to v44.1

Andreas Kienast CR +2 V +2 Nightmare +1783 −1768 updated 01/09/25, 14:53

Commit message

This commit updates ckeditor to v44.1.

Notable change: With v44, it became mandatory to provide a
`licenseKey` [1] in any case.

Executed commands:

    npm --prefix overrides/ckeditor5 version 44.1.0
    npm install --save ./overrides/ckeditor5 $(
        grep @ckeditor/ package.json | \
        grep -v @ckeditor/ckeditor5-dev-utils | \
        grep -v @ckeditor/ckeditor5-inspector | \
        sed 's/^[^"]*"\([^"]*\)".*/\1@44.1.0/' \
    )

[1] https://github.com/ckeditor/ckeditor5/blob/master/docs/updating/update-to-44.md#required-license-key-configuration

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 116

Show 96 more files

Review log 1113

  1. Andreas Kienast uploaded patch set 1 01/07/25, 13:30

  2. core-ci voted on patch set 1 V +1 01/07/25, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72046

  3. Benjamin Franzke commented on patch set 1 01/07/25, 13:56

    ckeditor5.ts:135

    We should allow this to be customizable via RTE config, should work by moving to before `...otherOptions`.
  4. Andreas Kienast commented on patch set 1 CR -1 01/07/25, 14:19

    ckeditor5.ts:135 Reply

    Ack
  5. Andreas Kienast uploaded patch set 2 CR -1 V +1 01/07/25, 14:21

  6. core-ci voted on patch set 2 V +1 01/07/25, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72049

  7. Andreas Kienast commented on patch set 2 01/07/25, 15:07

    ckeditor5.ts:135 Reply

    Done
  8. Benjamin Franzke voted on patch set 2 CR +1 V +1 01/08/25, 10:05

  9. Oliver Hader voted on patch set 2 CR +1 01/09/25, 12:23

  10. Stefan Bürk voted on patch set 2 CR +1 V +1 01/09/25, 14:12

  11. Andreas Kienast voted on patch set 2 CR +2 V +2 01/09/25, 14:34

  12. Benni Mack voted on patch set 2 CR +1 01/09/25, 14:47

  13. Andreas Kienast merged patch set 3 01/09/25, 14:53