87660[TASK] Add ScalarStringMatcher Extension Scanner for TYPO3_MODE reports
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Thomas Hohn +1
- Simon Praetorius +1
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Thomas Hohn +1
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 5
- typo3/sysext/install/Classes/Controller/UpgradeController.php+5 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/ScalarStringMatcher.php5new+75 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ScalarStringMatcher.phpnew+10 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ScalarStringMatcherFixture.phpnew+65 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ScalarStringMatcherTest.phpnew+117 −0
Review log 1721
-
Garvin Hicking uploaded patch set 1 01/07/25, 21:40
-
Garvin Hicking updated the commit message in patch set 2 01/07/25, 21:40
-
core-ci voted on patch set 1 V -1 01/07/25, 21:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72060
-
core-ci voted on patch set 2 V -1 01/07/25, 21:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72061
-
Garvin Hicking uploaded patch set 3
V -101/07/25, 22:29 -
core-ci voted on patch set 3 V +1 01/07/25, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72062
-
Lina Wolf commented on patch set 3 01/08/25, 07:01
This is very much needed! I am wondering however: When there is such a die(), can we ever make it all the way to the Extension scanner? did you test that? -
Garvin Hicking commented on patch set 3 01/08/25, 07:07
Reply
Yes! I tested it and it works conceptually because the extension scanner does not load the files but just statically analyzes them (like PHPstan via php-parser). Happy you find it useful, too! -
Oli Bartsch commented on patch set 3 V +1 01/08/25, 07:16
ScalarStringMatcher.php:65What's the reason for a "weak" match? Because it's a string? - Besides that, great patch and works! -
Garvin Hicking commented on patch set 3 01/08/25, 07:56
ScalarStringMatcher.php:65ReplyMy reasoning was that maybe the string could be used for other internal distinctions or so, just as plain variable content, yes. It is rather strong in reality, but we could raise that in the future if it proves helpful in real-life scenarios? -
Garvin Hicking uploaded patch set 4
V +101/08/25, 08:04Add test scenario for trimming and add note about weak match -
core-ci voted on patch set 4 V +1 01/08/25, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72081
-
Simon Praetorius commented on patch set 4 CR +1 01/08/25, 09:55
This is a great addition, future TYPO3-updating Simon thanks you! -
Garvin Hicking commented on patch set 4 01/08/25, 10:06
ScalarStringMatcher.php:65ReplyAdded a note for this to maybe adjust, ok for you? -
Oli Bartsch commented on patch set 4 CR +1 V +1 01/08/25, 10:29
ScalarStringMatcher.php:65ReplyAcknowledged -
Oli Bartsch commented on patch set 4 01/08/25, 10:29
ScalarStringMatcher.php:65ReplyDone -
Christian Kuhn voted on patch set 4 CR +1 V +1 01/08/25, 11:19
-
Thomas Hohn voted on patch set 4 CR +1 V +1 01/08/25, 11:22
-
Stefan Bürk voted on patch set 4 CR +1 V +1 01/09/25, 14:18
-
Garvin Hicking voted on patch set 4 CR +2 V +2 01/09/25, 14:27
-
Garvin Hicking merged patch set 5 01/09/25, 14:27