Review main Merged

87661[DOCS] Add Features section to EXT:seo manual

Lina Wolf CR +2 V +2 Normal +162 −74 updated 01/10/25, 08:48

Commit message

Additional Meta tag handling on top of https://docs.typo3.org/permalink/t3coreapi:metatagapi
Additional Title tag handling on top of https://docs.typo3.org/permalink/t3coreapi:pagetitle
HrefLang (?)
Out-of-the-box XML sitemap

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Lina Wolf uploaded patch set 1 01/08/25, 06:56

  2. core-ci voted on patch set 1 V +1 01/08/25, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72077

  3. Garvin Hicking commented on patch set 1 01/08/25, 19:13

    Index.rst:29

    Why dont we use a normal :ref: here? With the full link we would switch away from local rendering when reading the docs locally. For internal links we should probably stick to :ref:? (if so, replace all "/permalink/typo3/cms-seo" with local ref?)
  4. Garvin Hicking commented on patch set 1 CR +1 V +1 01/09/25, 10:29

    Index.rst:29 Reply

    Lina explained that the links are locally resolves despite the format, I was not aware of this. :)
  5. Benni Mack voted on patch set 1 CR +1 V +1 01/10/25, 08:35

  6. Garvin Hicking voted on patch set 1 CR +2 V +2 01/10/25, 08:39

  7. Garvin Hicking merged patch set 2 01/10/25, 08:48