Review main Merged

87667[TASK] Isolate functional test fixture assets for EXT:reactions

Garvin Hicking CR +2 V +2 Easy +7 −1 updated 01/13/25, 13:27

Commit message

This patch removes fixture cross-dependencies from EXT:reactions to
a be_users.csv file in EXT:core.

Assets are copied to be unique and prevent side-effects when
files are changed at their original location. Tests should be
side-effect free and isolated.

Remaining exemption for cross-dependencies are references to:

EXT:core/Tests/Functional/Fixtures/Frontend/JsonRenderer.typoscript
EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_csv
EXT:core/Tests/Functional/Fixtures/Extensions/test_eid
EXT:core/Tests/Functional/Fixtures/Extensions/test_classic_content
EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_mm
EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_mnsymmetric
EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield
EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributeinline
EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributesimple

These central fixtures should not be redundantly stored,
and are fittingly placed in the "EXT:core" space.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 4

Files 2

Review log 45

  1. Garvin Hicking uploaded patch set 1 01/08/25, 14:50

  2. core-ci voted on patch set 1 V +1 01/08/25, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72094

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 01/13/25, 12:49

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 01/13/25, 13:19

  5. Stefan Bürk merged patch set 2 01/13/25, 13:27