Review 13.4 Merged

87672[BUGFIX] Make some buttons reachable by keyboard

Benni Mack CR +2 V +2 Easy +18 −17 updated 01/08/25, 15:53

Commit message

This makes some buttons reachable by keyboard.

Before these buttons were implemented as `a`-tags with missing
`href`-attributes, and thereby were not focusable.

Used RegExp to find candidates for fixing:
`<a\b(?:(?!\b?href=)[^>])*>`

This also updates the 'styleguide' for 'modals' to show correct
trigger-buttons in example code.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Benni Mack commented on patch set 1 01/08/25, 15:31

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/08/25, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72100

  3. Benni Mack voted on patch set 1 CR +2 V +2 01/08/25, 15:53

  4. Benni Mack merged patch set 2 01/08/25, 15:53