87675[TASK] Ensure decorated `Connection->transactional()` method works
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Database/Connection.php+22 −0
- typo3/sysext/core/Tests/Functional/Database/Connection/TransactionalTest.phpnew+103 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_connection_transaction/Configuration/TCA/tx_testconnectiontransaction.php2new+36 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_connection_transaction/composer.jsonnew+14 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_connection_transaction/ext_emconf.phpnew+21 −0
Review log 912
-
Stefan Bürk uploaded patch set 1 01/09/25, 11:49
-
core-ci voted on patch set 1 V -1 01/09/25, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72136
-
Stefan Bürk uploaded patch set 2
V -101/09/25, 12:12 -
core-ci voted on patch set 2 V +1 01/09/25, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72139
-
Christian Kuhn commented on patch set 2 01/09/25, 17:46
v12 really needed? even with all the doctrine changes in v12? isnt' this problematic?tx_testconnectiontransaction.php:5minor simplification: i think we could easily inline such labels as not translated string directly: the point of this extension is not to test localizations, but to test something else ... let's keep it simple and get rid of the .xlf file ? -
Stefan Bürk uploaded patch set 3
V +101/09/25, 19:16 -
Stefan Bürk commented on patch set 3 01/09/25, 19:16
Reply
Removed 12.4.tx_testconnectiontransaction.php:5Replyack. done. -
core-ci voted on patch set 3 V +1 01/09/25, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72167
-
Christian Kuhn voted on patch set 3 CR +1 V +1 01/10/25, 10:07
-
Benni Mack voted on patch set 3 CR +1 V +1 01/10/25, 11:53
-
Stefan Bürk voted on patch set 3 CR +2 V +2 01/10/25, 13:07
-
Stefan Bürk merged patch set 4 01/10/25, 13:15