Review main Merged

87675[TASK] Ensure decorated `Connection->transactional()` method works

Stefan Bürk CR +2 V +2 Normal +196 −0 updated 01/10/25, 13:15

Commit message

TYPO3 decorates the `\Doctrine\DBAL\Connection` class with the custom
implementation `\TYPO3\CMS\Core\Database\Connection` and uses is as
the default connection managed by the `ConnectionPool`.

The `transactional()` method is not used by TYPO3 directly yet while
extension developers have a valid interest in a working state of the
simplified transaction handling.

This change adds some tests to ensure that simplified `transactional()`
handling works and adds the method to the decoracted class along with
a inline phpdocblock override to satisfy PHPStan revealed by the tests.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 912

  1. Stefan Bürk uploaded patch set 1 01/09/25, 11:49

  2. core-ci voted on patch set 1 V -1 01/09/25, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72136

  3. Stefan Bürk uploaded patch set 2 V -1 01/09/25, 12:12

  4. core-ci voted on patch set 2 V +1 01/09/25, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72139

  5. Christian Kuhn commented on patch set 2 01/09/25, 17:46

    v12 really needed? even with all the doctrine changes in v12? isnt' this problematic?

    tx_testconnectiontransaction.php:5

    minor simplification: i think we could easily inline such labels as not translated string directly: the point of this extension is not to test localizations, but to test something else ... let's keep it simple and get rid of the .xlf file ?
  6. Stefan Bürk uploaded patch set 3 V +1 01/09/25, 19:16

  7. Stefan Bürk commented on patch set 3 01/09/25, 19:16

    Reply

    Removed 12.4.

    tx_testconnectiontransaction.php:5 Reply

    ack. done.
  8. core-ci voted on patch set 3 V +1 01/09/25, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72167

  9. Christian Kuhn voted on patch set 3 CR +1 V +1 01/10/25, 10:07

  10. Benni Mack voted on patch set 3 CR +1 V +1 01/10/25, 11:53

  11. Stefan Bürk voted on patch set 3 CR +2 V +2 01/10/25, 13:07

  12. Stefan Bürk merged patch set 4 01/10/25, 13:15