Review main Merged

87678[TASK] Add required datetime field to EXT:styleguide

Garvin Hicking CR +2 V +2 Easy +9 −1 updated 01/09/25, 18:53

Commit message

A new field "input_3" is added to EXT:styleguide
for the "Formengine - required" handling.

Until now only a normal "date" (without time)
element was available. For future refactorings
and changes of the required field handling,
review module and datetime changes, this
should be available to test easily.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Garvin Hicking uploaded patch set 1 01/09/25, 16:02

  2. core-ci voted on patch set 1 V +1 01/09/25, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72150

  3. Garvin Hicking commented on patch set 2 V +1 01/09/25, 16:11

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 01/09/25, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72151

  5. Georg Ringer voted on patch set 2 CR +1 V +1 01/09/25, 17:39

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 01/09/25, 17:41

  7. Garvin Hicking voted on patch set 2 CR +2 V +2 01/09/25, 18:37

  8. Garvin Hicking merged patch set 3 01/09/25, 18:53